[Python-checkins] r42480 - python/trunk/Lib/bsddb/init.py

Sun Feb 19 02:47:22 CET 2006

On 2/18/06, Georg Brandl <g.brandl at gmx.net> wrote:
> Neal Norwitz wrote:
> > On 2/18/06, georg.brandl <python-checkins at python.org> wrote:
> >> Author: georg.brandl
> >> Date: Sun Feb 19 01:53:54 2006
> >> New Revision: 42480
> >>
> >> Modified:
> >> python/trunk/Lib/bsddb/__init__.py
> >> Log:
> >> Bug #1396678: a closed bsddb.DB raises AttributeError on repr().
> >>
> >> It now returns "{}". Is that the correct solution?
> >
> > iteritems() returns None. It seems like it should return an empty
> > iterator, such as: iter(()).
>> This iteritems() is a generator, so shouldn't it just return for
> an empty iterator?

Ah, I only looked at the diff, not the entire method. The updated
code looks fine to me.
> > How about adding a test for this? That will help determining the
> > correct solution and we know there won't be a regression in the
> > future.
>> Done.

Thanks!
n

[Python-checkins] r42480 - python/trunk/Lib/bsddb/__init__.py

[Python-checkins] r42480 - python/trunk/Lib/bsddb/init.py