[Python-checkins] r43741 - python/trunk/Modules/_sqlite/cursor.c

Sun Apr 9 06:07:39 CEST 2006

Author: neal.norwitz
Date: Sun Apr 9 06:07:39 2006
New Revision: 43741
Modified:
 python/trunk/Modules/_sqlite/cursor.c
Log:
Fix problem (not checking return result) reported by Coverity
Modified: python/trunk/Modules/_sqlite/cursor.c
==============================================================================

--- python/trunk/Modules/_sqlite/cursor.c	(original)
+++ python/trunk/Modules/_sqlite/cursor.c	Sun Apr 9 06:07:39 2006
@@ -455,6 +455,9 @@
 Py_DECREF(second_argument);
 
 parameters_iter = PyObject_GetIter(parameters_list);
+ if (!parameters_iter) {
+ goto error;
+ }
 }
 
 if (self->statement != NULL) {
@@ -670,7 +673,7 @@
 error:
 Py_XDECREF(operation_bytestr);
 Py_XDECREF(parameters);
- Py_DECREF(parameters_iter);
+ Py_XDECREF(parameters_iter);
 Py_XDECREF(parameters_list);
 
 if (PyErr_Occurred()) {
