[Python-checkins] python/dist/src/Misc NEWS,1.337.2.4.2.78,1.337.2.4.2.79
tim_one@users.sourceforge.net
tim_one@users.sourceforge.net
2003年5月21日 13:43:11 -0700
Update of /cvsroot/python/python/dist/src/Misc
In directory sc8-pr-cvs1:/tmp/cvs-serv23341/Misc
Modified Files:
Tag: release22-maint
NEWS
Log Message:
PyType_Ready(): Complain if the type is a base type, and gc'able, and
tp_free is NULL or PyObject_Del at the end. Because it's a base type
it must call tp_free in its dealloc function, and because it's gc'able
it must not call PyObject_Del.
inherit_slots(): Don't inherit tp_free unless the type and its base
agree about whether they're gc'able. If the type is gc'able and the
base is not, and the base uses the default PyObject_Del for its
tp_free, give the type PyObject_GC_Del for its tp_free (the appropriate
default for a gc'able type).
cPickle.c: The Pickler and Unpickler types claim to be base classes
and gc'able, but their dealloc functions didn't call tp_free.
Repaired that. Also call PyType_Ready() on these typeobjects, so
that the correct (PyObject_GC_Del) default memory-freeing function
gets plugged into these types' tp_free slots.
Index: NEWS
===================================================================
RCS file: /cvsroot/python/python/dist/src/Misc/NEWS,v
retrieving revision 1.337.2.4.2.78
retrieving revision 1.337.2.4.2.79
diff -C2 -d -r1.337.2.4.2.78 -r1.337.2.4.2.79
*** NEWS 20 May 2003 22:34:18 -0000 1.337.2.4.2.78
--- NEWS 21 May 2003 20:43:08 -0000 1.337.2.4.2.79
***************
*** 3,6 ****
--- 3,17 ----
============================
+ - C API: PyType_Ready(): If a type declares that it participates in gc
+ (Py_TPFLAGS_HAVE_GC), and its base class does not, and its base class's
+ tp_free slot is the default _PyObject_Del, and type does not define
+ a tp_free slot itself, _PyObject_GC_Del is assigned to type->tp_free.
+ Previously _PyObject_Del was inherited, which could at best lead to a
+ segfault. In addition, if even after this magic the type's tp_free
+ slot is _PyObject_Del or NULL, and the type is a base type
+ (Py_TPFLAGS_BASETYPE), TypeError is raised: since the type is a base
+ type, its dealloc function must call type->tp_free, and since the type
+ is gc'able, tp_free must not be NULL or _PyObject_Del.
+
- Windows: file.truncate(size) failed on large files when size didn't
fit in 32 bits. This was fixed by backporting new Windows truncation