[Python-checkins] CVS: python/dist/src/Lib urllib.py,1.141,1.142
Fred L. Drake, Jr.
fdrake@acm.org
Fri, 5 Apr 2002 14:31:00 -0500
Andrew MacIntyre writes:
> Accepting this part of #523415 wasn't what I expected. I just expected
> the docs only change to be applied (the most recent diff), based on my
> review comments to Andy.
Hmm. I didn't think the comments were very clear. I don't the the
doc patch without the implementation make a lot of sense. Perhaps the
proxies dictionary for FancyURLopener needed more documentation and
examples, but it may require some changes if the implementation
changes are revoked.
> Not that I have any in-principle objection to this part of the patch.
Nor do I have any in-principle objection to it being revoked. ;-)
I'll leave it as-is for now. In the future, it may be easiest for
tracker entries that involve implementation changes to only include
doc changes relevant to the impl change; general doc updates can go in
separate issues since the review process is much simpler.
Dependencies can be noted in the comments if needed.
I guess I should add that somewhere on python.org.
-Fred
--
Fred L. Drake, Jr. <fdrake at acm.org>
PythonLabs at Zope Corporation