On Feb 3, 2019, at 13:03, Antoine Pitrou <[email protected]> wrote: > > I'd like to ask for the reversion of the changes done in > https://github.com/python/cpython/pull/11664 > > The reason is simple: the PR isn't complete, it lacks docs and tests. > It also didn't pass any review (this was pointed by Ronald), even > though it adds 1300 lines of code. No programmer is perfect, so it's > statistically likely that the PR is defective.
I concur. I actually think CI shouldn’t even pass without sufficiently covering tests and docs (sans a "trivial" or other short circuiting label), but that might be unpopular. -Barry
Attachment:
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ Python-Dev mailing list [email protected] https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com