Re: [PATCH 5/5] kernel handling of CPU DLPAR
From: Brian King
Date: Tue Sep 15 2009 - 10:49:08 EST
Nathan Fontenot wrote:
>
+static ssize_t cpu_probe_store(struct class *class, const char *buf,
>
+ size_t count)
>
+{
>
+ struct device_node *dn;
>
+ u32 drc_index;
>
+ char *cpu_name;
>
+ int rc;
>
+
>
+ drc_index = simple_strtoull(buf, NULL, 0);
Can just use simple_strtoul here instead.
>
+ if (!drc_index)
>
+ return -EINVAL;
>
+
>
+ rc = acquire_drc(drc_index);
>
+ if (rc)
>
+ return rc;
>
+
>
+ dn = configure_connector(drc_index);
>
+ if (!dn) {
>
+ release_drc(drc_index);
>
+ return rc;
>
+ }
>
+
>
+ /* fixup dn name */
>
+ cpu_name = kzalloc(strlen(dn->full_name) + strlen("/cpus/") + 1,
>
+ GFP_KERNEL);
>
+ sprintf(cpu_name, "/cpus/%s", dn->full_name);
>
+ kfree(dn->full_name);
>
+ dn->full_name = cpu_name;
>
+
>
+ rc = add_device_tree_nodes(dn);
>
+ if (rc)
>
+ release_drc(drc_index);
>
+
>
+ return rc ? rc : count;
>
+}
>
+
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/