Re: [PATCH] Make sure the value in abs() does not get truncated ifit is greater than 2^32
From: Jesper Juhl
Date: Fri Sep 11 2009 - 18:54:21 EST
On Thu, 3 Sep 2009, Rolf Eike Beer wrote:
>
I was just digging a bit around in linux/kernel.h and stumbled over the abs()
>
makro. For me it looks as it would return wrong results on 64 bit platforms
>
if the input value is greater than 2^32.
>
I think you are right.
>
Signed-off-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
>
---
>
include/linux/kernel.h | 2 +-
>
1 files changed, 1 insertions(+), 1 deletions(-)
>
>
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
>
index d6320a3..1e6eb66 100644
>
--- a/include/linux/kernel.h
>
+++ b/include/linux/kernel.h
>
@@ -145,7 +145,7 @@ extern int _cond_resched(void);
>
#define might_sleep_if(cond) do { if (cond) might_sleep(); } while (0)
>
>
#define abs(x) ({ \
>
- int __x = (x); \
>
+ long __x = (x); \
>
(__x < 0) ? -__x : __x; \
>
})
>
>
--
Jesper Juhl <jj@xxxxxxxxxxxxx>
http://www.chaosbits.net/
Plain text mails only, please
http://www.expita.com/nomime.html
Don't top-post
http://www.catb.org/~esr/jargon/html/T/top-post.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/