Re: qla2xxx: Correct compilation issues when CONFIG_MOUDLES=n (was:Re: linux-next: Tree for September 7 (scsi/qla2x))
From: Randy Dunlap
Date: Fri Sep 11 2009 - 17:26:05 EST
On 2009年9月11日 10:53:41 -0700 Andrew Vasquez wrote:
>
Randy Dunlap noted:
>
>
when CONFIG_MODULES=n:
>
>
drivers/scsi/qla2xxx/qla_os.c:2685: error: dereferencing pointer to incomplete type
>
>
in
>
kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj,
>
KOBJ_CHANGE, envp);
>
>
Signed-off-by: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
Ok, So any strong objections to just having the functionality present
>
when module support is enabled?
Fine with me. Thanks.
>
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
>
index 29396c0..3887adb 100644
>
--- a/drivers/scsi/qla2xxx/qla_os.c
>
+++ b/drivers/scsi/qla2xxx/qla_os.c
>
@@ -2671,6 +2671,7 @@ qla2x00_post_uevent_work(struct scsi_qla_host *vha, u32 code)
>
static void
>
qla2x00_uevent_emit(struct scsi_qla_host *vha, u32 code)
>
{
>
+#ifdef CONFIG_MODULES
>
char event_string[40];
>
char *envp[] = { event_string, NULL };
>
>
@@ -2685,6 +2686,7 @@ qla2x00_uevent_emit(struct scsi_qla_host *vha, u32 code)
>
}
>
kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj,
>
KOBJ_CHANGE, envp);
>
+#endif
>
}
>
>
void
>
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/