Re: [RFC] mm: Honor min_free_kbytes set by user
From: Michal Hocko
Date: Thu Jul 04 2013 - 12:20:14 EST
On Thu 04-07-13 18:16:41, Michal Hocko wrote:
>
On Thu 04-07-13 09:10:39, Joe Perches wrote:
>
> On Thu, 2013年07月04日 at 18:07 +0200, Michal Hocko wrote:
>
> > A warning is printed when the new value is ignored.
>
>
>
> []
>
>
>
> > + printk(KERN_WARNING "min_free_kbytes is not updated to %d"
>
> > + "because user defined value %d is preferred\n",
>
> > + new_min_free_kbytes, user_min_free_kbytes);
>
>
>
> Please use pr_warn and coalesce the format.
>
>
Sure can do that. mm/page_alloc.c doesn't seem to be unified in that
>
regards (44 printks and only 4 pr_<foo>) so I used printk.
>
>
> You'd've noticed a missing space between %d and because.
>
>
True
>
Checkpatch fixes
---