Re: [PATCH 09/13] sched: Favour moving tasks towards nodes thatincurred more faults
From: Mel Gorman
Date: Thu Jul 04 2013 - 05:25:10 EST
On Wed, Jul 03, 2013 at 08:27:48PM +0200, Peter Zijlstra wrote:
>
On Wed, Jul 03, 2013 at 03:21:36PM +0100, Mel Gorman wrote:
>
> static bool migrate_improves_locality(struct task_struct *p, struct lb_env *env)
>
> {
>
>
> + if (p->numa_faults[task_faults_idx(dst_nid, 1)] >
>
> + p->numa_faults[task_faults_idx(src_nid, 1)])
>
> + return true;
>
>
> +}
>
>
> +static bool migrate_degrades_locality(struct task_struct *p, struct lb_env *env)
>
> +{
>
>
> + if (p->numa_faults[src_nid] > p->numa_faults[dst_nid])
>
> return true;
>
>
I bet you wanted to use task_faults_idx() there too ;-)
>
You won that bet. Fixed.
--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/