Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()
From: Michael Holzheu
Date: Wed Jul 03 2013 - 09:59:48 EST
On Tue, 2 Jul 2013 11:42:14 -0400
Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
>
On Mon, Jul 01, 2013 at 09:32:37PM +0200, Michael Holzheu wrote:
[snip]
>
> This handler works as follows:
>
>
>
> * Get already available or new page from page cache (find_or_create_page)
>
> * Check if /proc/vmcore page is filled with data (PageUptodate)
>
> * If yes:
>
> Return that page
>
> * If no:
>
> Fill page using __vmcore_read(), set PageUptodate, and return page
>
>
>
> Signed-off-by: Michael Holzheu <holzheu@xxxxxxxxxxxxxxxxxx>
>
>
In general vmcore related changes look fine to me. I am not very familiar
>
with the logic of finding pages in page cache and using page uptodate
>
flag.
>
>
Hatayama, can you please review it.
>
>
Acked-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
Hello Vivek,
If Hatayama accepts the patch, should we then send the patch series to
Andrew Morton?
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/