image list displays a maximum of 25 images

Bug Description

1. Set env vars for HP Helion Public Cloud [1]

export OS_TENANT_NAME=xxx
export OS_USERNAME=xxx
export OS_PASSWORD=xxx
export OS_AUTH_URL=https://region-b.geo-1.identity.hpcloudsvc.com:35357/v2.0/
export OS_REGION_NAME=region-b.geo-1

2. List images

$ openstack image list
...
[25 images displayed]
...

If you go to the Images page [2], you see that there are 103 images available.

[1] https://community.hpcloud.com/article/command-line-interface-cli-tool-installation-instructions
[2] https://horizon.hpcloud.com/project/images/

whats the output of # glance image-list?

looks like glanceclient has an option for page size:
https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/images.py#L206

page_size = kwargs.get('page_size', DEFAULT_PAGE_SIZE) where DEFAULT_PAGE_SIZE is 20.

I wonder how horizon and glance CLI handle this, or HP public cloud for that matter.

horizon has a setting and glanceclient CLI has a page-size option:

glance CLI:
https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/shell.py#L56
@utils.arg('--page-size', metavar='<SIZE>', default=None, type=int,
help='Number of images to request in each paginated request.')

horizon:
https://github.com/openstack/horizon/blob/8e223c950ed69e80034fc8ef7d0861ecd8aeb07d/openstack_dashboard/api/glance.py#L66-L69
def image_list_detailed(request, marker=None, sort_dir='desc',
sort_key='created_at', filters=None, paginate=False):
limit = getattr(settings, 'API_RESULT_LIMIT', 1000)
page_size = utils.get_page_size(request)

Also... looks like OSC had this at one point?

https://github.com/openstack/python-openstackclient/blob/master/openstackclient/image/v1/image.py#L351-L357

@Everett, want to try using `openstack image list --page-size 120` ?

Just tried `openstack image list --page-size 120` and got the same 25 images only result. Note that `openstack help image list` doesn't mention anything about --page-size.

`glance image-list` returns 103 images.

Cool. I wasn't expecting --page-size to show up in the help output, that option is suppressed for some reason.

Looking at this a bit further... apparently this option never worked. Glance is using pagination (and filtering?) so this is getting ugly really fast.

Added a 'limit' option, and that seems to solve things. Don't know if it agrees with dtroyers vision of handling paging going forward thought.

steve:python-openstackclient$ openstack image list | wc -l
29
steve:python-openstackclient$ openstack image list --limit 100 | wc -l
33

Tested with >25 images created.

Not sure how to glanceclient is warping this to get everything by default. Also not sure if that's something we want to encourage.

FYI - the limit option does not exist in the current OSC code / release. Just something I'm playing around with in my env.

@Everett, is this using v1 or v2 of the images API?

Looks like HP is using v1 API [1].

$ openstack --debug image list
...
DEBUG: openstackclient.image.client Instantiating image api: <class 'openstackclient.api.image_v1.APIv1'>
DEBUG: keystoneclient.session REQ: curl -g -i -X GET https://region-b.geo-1.images.hpcloudsvc.com:443/v1.0/images -H "User-Agent: python-keystoneclient" -H "X-Auth-Token: {SHA1}xxx"

Hmmmmm...tried this on Rackspace too expecting the v2 API [2]. It returns the same 25 only images but I get this wackiness.

$ openstack --debug image list
...
DEBUG: openstackclient.image.client Instantiating image api: <class 'openstackclient.api.image_v1.APIv1'>
DEBUG: keystoneclient.session REQ: curl -g -i -X GET https://iad.images.api.rackspacecloud.com/v2/v1/images -H "User-Agent: python-keystoneclient" -H "X-Auth-Token: {SHA1}xxx"

I'm not too sure what to make of that. https://iad.images.api.rackspacecloud.com/v2/v1/images isn't a valid URL. Maybe openstack --debug isn't logging what's really going on?

[1] https://github.com/openstack/os-client-config/blob/master/os_client_config/vendors.py#L23
[2] https://github.com/openstack/os-client-config/blob/master/os_client_config/vendors.py#L32

fixed in https://review.openstack.org/#/c/173420/

Change abandoned by Steve Martinelli (<email address hidden>) on branch: master
Review: https://review.openstack.org/172763
Reason: i'll revisit this after the summit

Correction: The current releases only contains the code for v1 API and not for v2. Is there any reason for that? From a user perspective it is a clear regression over the use of the old glance CLI tool.

Fixed in https://review.openstack.org/#/c/406200/

This fix should be backported to the Ubuntu packages.

This bug was fixed in the package python-openstackclient - 3.4.1-0ubuntu2

---------------
python-openstackclient (3.4.1-0ubuntu2) zesty; urgency=medium

* debian/patches/max-images.patch: Allow more than maximum of 25 images to
be listed. (LP: #1443089)

-- Chuck Short <email address hidden> 2016年12月12日 08:33:47 -0500