Issue 7011047: code review 7011047: io/ioutil: fix Discard data race

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(596)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7011047: code review 7011047: io/ioutil: fix Discard data race (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bradfitz

Modified:
13 years ago

Reviewers:

CC:
golang-dev, iant, dvyukov

Visibility:
Public.

io/ioutil: fix Discard data race Fixes issue 4589

Patch Set 1 #

Patch Set 2 : diff -r 2e40253cdd9b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2e40253cdd9b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b07c0f6d6b5f https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -17 lines)			Patch
M	src/pkg/io/ioutil/blackhole.go	View	1	1 chunk	+14 lines, -4 lines	0 comments	Download
R	src/pkg/io/ioutil/blackhole_race.go	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/pkg/io/ioutil/ioutil.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2012年12月26日 21:03:27 UTC) #1

Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://go.googlecode.com/hg/

iant

LGTM

13 years ago (2012年12月27日 00:12:34 UTC) #2

LGTM

dvyukov

LGTM

13 years ago (2012年12月28日 10:30:29 UTC) #3

LGTM

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=4b61f121966b *** io/ioutil: fix Discard data race Fixes issue 4589 R=golang-dev, iant, ...

13 years ago (2012年12月28日 17:33:28 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=4b61f121966b ***
io/ioutil: fix Discard data race
Fixes issue 4589
R=golang-dev, iant, dvyukov
CC=golang-dev
https://codereview.appspot.com/7011047

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b