Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 9a33d0c

Browse files
committed
fix: light mode showing dark & vice versa
1 parent 292b9d7 commit 9a33d0c

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

‎src/popup/settings.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
</select>
2121
<button id="enable-dark-theme-btn" class="material-button settings-btn">
2222
<span id="theme-icon"></span>
23-
<spanid="theme-text">Dark mode</span>
23+
<span>Theme: </span><spanid="theme-text">Dark</span>
2424
</button>
2525
<button id="show-company-tags-btn" class="material-button settings-btn">
2626
<span id="show-company-tags-icon"> </span> Show Company Tags

‎src/popup/settings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ document.addEventListener('DOMContentLoaded', () => {
3838
const themeText = document.getElementById('theme-text');
3939
if (themeIcon && themeText) {
4040
themeIcon.textContent = '🔄';
41-
themeText.textContent = 'Auto Theme';
41+
themeText.textContent = 'Auto';
4242
}
4343
}
4444
}

‎src/utils/theme.ts

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,18 @@ export function toggleTheme(): void {
2222

2323
if (currentMode === 'manual') {
2424
if (currentTheme === 'dark') {
25-
// Dark -> Light
25+
// If we're in dark mode, switch to light mode
2626
newTheme = 'light';
2727
newMode = 'manual';
2828
} else {
29-
// Light -> Auto
29+
// If we're in light mode, switch to auto mode
3030
newMode = 'auto';
3131
// When switching to auto mode, try to detect theme immediately
3232
tryDetectThemeInPopup();
3333
return; // Exit early as tryDetectThemeInPopup will handle the rest
3434
}
3535
} else {
36-
// Auto -> Dark
36+
// If we're in auto mode, switch to dark mode
3737
newTheme = 'dark';
3838
newMode = 'manual';
3939
}
@@ -120,13 +120,16 @@ function updateThemeUI(theme: string, mode: string = 'manual') {
120120
if (!themeIcon || !themeText) return;
121121

122122
if (mode === 'auto') {
123+
// Show that auto theme is enabled
123124
themeIcon.textContent = '🔄';
124-
themeText.textContent = 'Auto Theme';
125+
themeText.textContent = 'Auto';
125126
} else if (theme === 'dark') {
126-
themeIcon.textContent = '☀️';
127-
themeText.textContent = 'Light Mode';
128-
} else {
127+
// Show that dark theme is enabled
129128
themeIcon.textContent = '🌙';
130-
themeText.textContent = 'Dark Mode';
129+
themeText.textContent = 'Dark';
130+
} else {
131+
// Show that light theme is enabled
132+
themeIcon.textContent = '☀️';
133+
themeText.textContent = 'Light';
131134
}
132135
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /