Commit 396f040

authored

fix: handle binary diff without extended header (#23)

1 parent 62d8908 commit 396f040Copy full SHA for 396f040

File tree

+16

-2

lines changed

+16

-2

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,6 @@`
`1`	`1`	`diff --git a/file1 b/file1`
`2`	`2`	`index 21be030..9443748 100644`
`3`		`-Binary files a/file1 and b/file1 differ`
	`3`	`+Binary files a/file1 and b/file1 differ`
	`4`	`+diff --git a/file1 b/file2`
	`5`	`+index 21be030..9443748 100644`
	`6`	`+Binary files a/file1 and b/file2 differ`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -14,6 +14,17 @@ exports[`changed binary file parse \`changed-binary-file\` 1`] = `
`14`	`14`	`"path": "file1",`
`15`	`15`	`"type": "ChangedFile",`
`16`	`16`	`},`
	`17`	`+ {`
	`18`	`+ "chunks": [`
	`19`	`+ {`
	`20`	`+ "pathAfter": "file2",`
	`21`	`+ "pathBefore": "file1",`
	`22`	`+ "type": "BinaryFilesChunk",`
	`23`	`+ },`
	`24`	`+ ],`
	`25`	`+ "path": "file2",`
	`26`	`+ "type": "ChangedFile",`
	`27`	`+ },`
`17`	`28`	`],`
`18`	`29`	`"type": "GitDiff",`
`19`	`30`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ function parseFileChange(ctx: Context): AnyFileChange \| undefined {`
`117`	`117`	`} else if (`
`118`	`118`	`chunks.length &&`
`119`	`119`	`chunks[0].type === 'BinaryFilesChunk' &&`
`120`		`- chunks[0].pathAfter===chunks[0].pathBefore`
	`120`	`+ chunks[0].pathAfter`
`121`	`121`	`) {`
`122`	`122`	`return {`
`123`	`123`	`type: FileType.Changed,`

Comments

(0)