Commit 784c88a

authored

fix: initial disabled controller state (jscottsmith#210) (jscottsmith#211)

1 parent cc95a1b commit 784c88aCopy full SHA for 784c88a

File tree

-8

lines changed

-8

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -68,8 +68,8 @@ describe('A <ParallaxProvider>', () => {`
`68`	`68`
`69`	`69`	`expect(`
`70`	`70`	`// @ts-expect-error`
`71`		`- parallaxController.disableParallaxController`
`72`		`- ).toBeCalled();`
	`71`	`+ parallaxController.disabled`
	`72`	`+ ).toBe(true);`
`73`	`73`
`74`	`74`	`context.rerender(`
`75`	`75`	`<ParallaxProvider>`

Lines changed: 1 addition & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,15 +17,10 @@ export class ParallaxProvider extends Component<ParallaxProviderProps, {}> {`
`17`	`17`	`this.controller = createController({`
`18`	`18`	`scrollAxis: props.scrollAxis,`
`19`	`19`	`scrollContainer: props.scrollContainer,`
	`20`	`+ disabled: props.isDisabled,`
`20`	`21`	`});`
`21`	`22`	`}`
`22`	`23`
`23`		`- componentDidMount() {`
`24`		`- if (this.props.isDisabled) {`
`25`		`- this.controller?.disableParallaxController();`
`26`		`- }`
`27`		`- }`
`28`		`-`
`29`	`24`	`componentDidUpdate(prevProps: ParallaxProviderProps) {`
`30`	`25`	`if (`
`31`	`26`	`prevProps.scrollContainer !== this.props.scrollContainer &&`

Comments

(0)