-
Notifications
You must be signed in to change notification settings - Fork 22
New naming and overall concept for this repo #180
-
Taking into account that:
- The software contained in this repo is now used on EVM-compatible chains that are not Ethereum.
- Some of the new targets are EVM-compatible but not strictly EVM, e.g. Boba is OVM.
- This repo will soon be better structured, with a clear separation between the contracts allowing the relay of requests and results between smart contract platforms and Witnet, and accessory contracts and interfaces.
- The current content of this repo is now available on NPM as
witnet-ethereum-bridge 0.2.0. - We have other solidity contracts in other repositories (e.g.
witnet-price-feed-examples) - Solidity monorepos are more convenient to manage, and quite standard today (see Chainlink, ADO, OpenZeppelin, etc.)
I'm proposing:
- Renaming this repo and its NPM package to
witnet-solidity. - Imports by end users would look like this:
import "witnet-solidity/contracts/UsingWitnet.sol". - Move every relevant Solidity contract we have into this repo.
- Examples should have a directory for their own, something like
/contracts/examples/.
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 3 comments 5 replies
-
I like the idea of changing ethereum to solidity within the repo's name. But naming it just as witnet-solidity would perhaps be too generic, as we do have other "solitidy" repos. So what about any of these other options?
- witnet-solidity-bridge
- witnet-solidity-board
- witnet-solidity-request-board
Beta Was this translation helpful? Give feedback.
All reactions
-
My point is that we may want not to have any more solidity repos and rather move everything here.
Beta Was this translation helpful? Give feedback.
All reactions
-
But maybe that's too big of a change, and given the latest changes on the price feeds example repository (which added a lot of boilerplate), my initial position of merging the examples into this repo are not a great idea anymore.
Beta Was this translation helpful? Give feedback.
All reactions
-
So I'm fine with witnet-solidity-bridge
Beta Was this translation helpful? Give feedback.
All reactions
-
I agree on having it renamed witnet-solidity-bridge. If the examples are the pricefeeds I also think is better to have them in a different repository so that we can update them or add new ones without affecting this repo.
Anyway could be a good idea to add a link to the pricefeeds repository in the README of this repo, in case someone wants to see an example
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 1
-
I'd like to hear from @clbartoli.
Also summoning @mariocao just in case.
Beta Was this translation helpful? Give feedback.
All reactions
-
So, it looks like witnet-solidity-bridge be it!
Beta Was this translation helpful? Give feedback.
All reactions
-
Repo has been renamed. README renaming and documentation updating is due.
Beta Was this translation helpful? Give feedback.