This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Commit e88d178

committed

Reset timeout onUnmount

1 parent effbe86 commit e88d178Copy full SHA for e88d178

File tree

+22

-1

lines changed

+22

-1

lines changed

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -97,4 +97,24 @@ describe("withTimeout", () => {`
`97`	`97`	`}, halfPeriod);`
`98`	`98`	`}, halfPeriod);`
`99`	`99`	`});`
	`100`	`+`
	`101`	`+ it("should not call timeout after unmount", (done) => {`
	`102`	`+ const props = {`
	`103`	`+ transitionState: {`
	`104`	`+ inTransition: false,`
	`105`	`+ },`
	`106`	`+ transitionInfo: {`
	`107`	`+ totalDuration: 20,`
	`108`	`+ },`
	`109`	`+ timeout: spy(),`
	`110`	`+ };`
	`111`	`+ const timeoutIn = props.transitionInfo.totalDuration * timeoutMultiplier;`
	`112`	`+ const wrapper = mount(<Assembly {...props} />);`
	`113`	`+ wrapper.setProps({ transitionState: { inTransition: true } });`
	`114`	`+ wrapper.unmount();`
	`115`	`+ setTimeout(() => {`
	`116`	`+ assert.isFalse(props.timeout.called);`
	`117`	`+ done();`
	`118`	`+ }, timeoutIn);`
	`119`	`+ });`
`100`	`120`	`});`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { withHandlers, isolate, onWillReceiveProps, debug } from "reassemble";`
	`1`	`+import { withHandlers, isolate, onWillReceiveProps, onWillUnmount } from "reassemble";`
`2`	`2`
`3`	`3`	`import { CSSTransitionProps } from "../csstransition";`
`4`	`4`	`import { WithTransitionStateProps } from "./withTransitionState";`
`@@ -45,4 +45,5 @@ export const withTimeout =`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`	`}),`
	`48`	`+ onWillUnmount<PropsUnion>(({ cancel }) => cancel()),`
`48`	`49`	`);`

Comments

(0)