Commit 3a64116

authored

Fixes onLoad*, onError events not called from child component

If the child component also defines the same onload methods this component defines, then this component's events won't be called and thus the bar will not render.

1 parent 44176b7 commit 3a64116Copy full SHA for 3a64116

File tree

1 file changed

-1

lines changed

lib
- webview.js

1 file changed

-1

lines changed

`‎lib/webview.js‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -67,12 +67,12 @@ class ProgressBarWebView extends React.PureComponent {`
`67`	`67`	`<View style={styles.container}>`
`68`	`68`	`{visible && <LoadingBar height={height} color={color} percent={percent}/>}`
`69`	`69`	`<WebView`
	`70`	`+ {...this.props}`
`70`	`71`	`ref={forwardedRef}`
`71`	`72`	`onLoadStart={this._onLoadStart}`
`72`	`73`	`onLoadEnd={this._onLoadEnd}`
`73`	`74`	`onLoadProgress={this._onLoadProgress}`
`74`	`75`	`onError={this._onError}`
`75`		`- {...this.props}`
`76`	`76`	`/>`
`77`	`77`	`</View>`
`78`	`78`	`);`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 3a64116

File tree

1 file changed

1 file changed

`‎lib/webview.js‎`

0 commit comments