Commit fa1675c

authored

Fix false positive for filename in vue/multi-word-component-names rule (#1689)

1 parent c6ca602 commit fa1675cCopy full SHA for fa1675c

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`// Requirements`
`9`	`9`	`// ------------------------------------------------------------------------------`
`10`	`10`
	`11`	`+const path = require('path')`
`11`	`12`	`const casing = require('../utils/casing')`
`12`	`13`	`const utils = require('../utils')`
`13`	`14`
`@@ -111,7 +112,7 @@ module.exports = {`
`111`	`112`	`if (hasName) return`
`112`	`113`	`if (!hasVue && node.body.length > 0) return`
`113`	`114`	`const fileName = context.getFilename()`
`114`		`- const componentName = fileName.replace(/\.[^/.]+$/,'')`
	`115`	`+ const componentName = path.basename(fileName,path.extname(fileName))`
`115`	`116`	`if (`
`116`	`117`	`utils.isVueFile(fileName) &&`
`117`	`118`	`!isValidComponentName(componentName)`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,10 @@ tester.run('multi-word-component-names', rule, {`
`39`	`39`	`filename: 'app.vue',`
`40`	`40`	`code: ''`
`41`	`41`	`},`
	`42`	`+ {`
	`43`	`+ filename: 'path/to/app.vue',`
	`44`	`+ code: '<script></script>'`
	`45`	`+ },`
`42`	`46`	`{`
`43`	`47`	`filename: 'invalid.vue',`
`44`	`48`	code: `

Comments

(0)