Commit f3c609d

mysticateamichalsnik

authored and

committed

Fix: unintentional disabling (#331)

1 parent 41e7eee commit f3c609dCopy full SHA for f3c609d

File tree

+19

-2

lines changed

+19

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,8 @@`
`8`	`8`	`// Helpers`
`9`	`9`	`// -----------------------------------------------------------------------------`
`10`	`10`
`11`		`-const COMMENT_DIRECTIVE_B = /^\s(eslint-(?:en\|dis)able)\s(?:(\S\|\S[\s\S]\S)\s)?$/`
`12`		`-const COMMENT_DIRECTIVE_L = /^\s(eslint-disable(?:-next)?-line)\s(?:(\S\|\S[\s\S]\S)\s)?$/`
	`11`	`+const COMMENT_DIRECTIVE_B = /^\s(eslint-(?:en\|dis)able)(?:\s+(\S\|\S[\s\S]\S))?\s*$/`
	`12`	`+const COMMENT_DIRECTIVE_L = /^\s(eslint-disable(?:-next)?-line)(?:\s+(\S\|\S[\s\S]\S))?\s*$/`
`13`	`13`
`14`	`14`	`/**`
`15`	`15`	`* Parse a given comment.`

Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -191,5 +191,22 @@ describe('comment-directive', () => {`
`191`	`191`	`assert.deepEqual(messages[0].ruleId, 'vue/no-parsing-error')`
`192`	`192`	`assert.deepEqual(messages[1].ruleId, 'vue/no-duplicate-attributes')`
`193`	`193`	`})`
	`194`	`+`
	`195`	`+ it('should affect only the next line', () => {`
	`196`	+ const code = `
	`197`	`+ <template>`
	`198`	`+ <!-- eslint-disable-next-line vue/no-parsing-error, vue/no-duplicate-attributes -->`
	`199`	`+ <div id id="a">Hello</div>`
	`200`	`+ <div id id="b">Hello</div>`
	`201`	`+ </template>`
	`202`	+ `
	`203`	`+ const messages = linter.executeOnText(code, 'test.vue').results[0].messages`
	`204`	`+`
	`205`	`+ assert.deepEqual(messages.length, 2)`
	`206`	`+ assert.deepEqual(messages[0].ruleId, 'vue/no-parsing-error')`
	`207`	`+ assert.deepEqual(messages[0].line, 5)`
	`208`	`+ assert.deepEqual(messages[1].ruleId, 'vue/no-duplicate-attributes')`
	`209`	`+ assert.deepEqual(messages[1].line, 5)`
	`210`	`+ })`
`194`	`211`	`})`
`195`	`212`	`})`

Comments

(0)