Commit e9d4400

committed

feature: code cleanup

1 parent 0e6ea56 commit e9d4400Copy full SHA for e9d4400

File tree

2 files changed

+12

-14

lines changed

docs/rules
- define-props-declaration.md
lib/rules
- define-props-declaration.js

2 files changed

+12

-14

lines changed

`‎docs/rules/define-props-declaration.md‎`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -43,17 +43,13 @@ const props = defineProps({`
`43`	`43`	```json
`44`	`44`	`{`
`45`	`45`	`"vue/define-props-declaration": ["error",`
`46`		`- "type-based" \| "runtime",`
`47`		`- {`
`48`		`- "autoFixToSeparateInterface": false`
`49`		`- }`
	`46`	`+ "type-based" \| "runtime"`
`50`	`47`	`]`
`51`	`48`	`}`
`52`	`49`	```
`53`	`50`
`54`	`51`	- `type-based` (default) enforces type-based declaration
`55`	`52`	- `runtime` enforces runtime declaration
`56`		-- `autoFixToSeparateInterface` (`boolean`) define `interface Props` used for type-based declaration instead of providing types inline
`57`	`53`
`58`	`54`	### `"runtime"`
`59`	`55`

`‎lib/rules/define-props-declaration.js‎`

Lines changed: 11 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,10 @@`
`6`	`6`
`7`	`7`	`const utils = require('../utils')`
`8`	`8`
	`9`	`+/**`
	`10`	`+ * @typedef {import('../utils').ComponentProp} ComponentProp`
	`11`	`+ */`
	`12`	`+`
`9`	`13`	`const PROPS_SEPARATOR = ', '`
`10`	`14`
`11`	`15`	`/**`
`@@ -53,8 +57,11 @@ function* fixTypeBased(fixer, node, props, context) {`
`53`	`57`	`}`
`54`	`58`	`return null`
`55`	`59`	`}`
`56`		`-const mapNativeType = (/** @type {string} */ nativeType) => {`
`57`		`- switch (nativeType) {`
	`60`	`+ /**`
	`61`	`+ * @param {string} nativeType`
	`62`	`+ * @returns {string}`
	`63`	`+ */`
	`64`	`+const mapNativeType = (nativeType) => {switch (nativeType) {`
`58`	`65`	`case 'String': {`
`59`	`66`	`return 'string'`
`60`	`67`	`}`
`@@ -125,7 +132,6 @@ function optionGetType(node, sourceCode) {`
`125`	`132`	`case 'ArrayExpression': {`
`126`	`133`	`return node.elements`
`127`	`134`	`.map((element) => {`
`128`		`- // TODO handle SpreadElement`
`129`	`135`	`if (element === null \|\| element.type === 'SpreadElement') {`
`130`	`136`	`return sourceCode.getText(node)`
`131`	`137`	`}`
`@@ -175,7 +181,7 @@ function optionGetType(node, sourceCode) {`
`175`	`181`
`176`	`182`	`/**`
`177`	`183`	`* @param {Expression} node`
`178`		`- * @returns {boolean \| undefined }`
	`184`	`+ * @returns {boolean}`
`179`	`185`	`*/`
`180`	`186`	`function optionGetRequired(node) {`
`181`	`187`	`if (node.type === 'ObjectExpression') {`
`@@ -195,7 +201,7 @@ function optionGetRequired(node) {`
`195`	`201`
`196`	`202`	`/**`
`197`	`203`	`* @param {Expression} node`
`198`		`- * @returns {Expression \| undefined}`
	`204`	`+ * @returns {Expression \| undefined}`
`199`	`205`	`*/`
`200`	`206`	`function optionGetDefault(node) {`
`201`	`207`	`if (node.type === 'ObjectExpression') {`
`@@ -211,10 +217,6 @@ function optionGetDefault(node) {`
`211`	`217`	`return undefined`
`212`	`218`	`}`
`213`	`219`
`214`		`-/**`
`215`		`- * @typedef {import('../utils').ComponentProp} ComponentProp`
`216`		`- */`
`217`		`-`
`218`	`220`	`module.exports = {`
`219`	`221`	`meta: {`
`220`	`222`	`type: 'suggestion',`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit e9d4400

File tree

2 files changed

2 files changed

`‎docs/rules/define-props-declaration.md‎`

`‎lib/rules/define-props-declaration.js‎`

0 commit comments