Commit dd6ed4f

armano2mysticatea

authored and

committed

Fix: Ignore templates with 'src' attribute in no-unused-components (fixes #598)(#607)

1 parent 096949b commit dd6ed4fCopy full SHA for dd6ed4f

File tree

+27

-2

lines changed

+27

-2

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,8 @@ module.exports = {`
`66`	`66`	`"VElement[name='template']:exit" (rootNode) {`
`67`	`67`	`if (`
`68`	`68`	`rootNode.loc.start !== templateLocation \|\|`
`69`		`- ignoreReporting`
	`69`	`+ ignoreReporting \|\|`
	`70`	`+ utils.hasAttribute(rootNode, 'src')`
`70`	`71`	`) return`
`71`	`72`
`72`	`73`	`registeredComponents`

Lines changed: 25 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ tester.run('no-unused-components', rule, {`
`334`	`334`	`options: [{ ignoreWhenBindingPresent: true }]`
`335`	`335`	`},`
`336`	`336`
`337`		- // Ignore when `render` is used instead of temoplate
	`337`	+ // Ignore when `render` is used instead of template
`338`	`338`	`{`
`339`	`339`	`filename: 'test.vue',`
`340`	`340`	code: `
`@@ -348,6 +348,30 @@ tester.run('no-unused-components', rule, {`
`348`	`348`	`}`
`349`	`349`	`}`
`350`	`350`	</script>`
	`351`	`+ },`
	`352`	`+ {`
	`353`	`+ filename: 'test.vue',`
	`354`	+ code: `
	`355`	`+ <template src="./test.html" />`
	`356`	`+ <script>`
	`357`	`+ export default {`
	`358`	`+ components: {`
	`359`	`+ TheButton`
	`360`	`+ }`
	`361`	`+ }`
	`362`	+ </script>`
	`363`	`+ },`
	`364`	`+ {`
	`365`	`+ filename: 'test.vue',`
	`366`	+ code: `
	`367`	`+ <template src="./test.html"></template>`
	`368`	`+ <script>`
	`369`	`+ export default {`
	`370`	`+ components: {`
	`371`	`+ TheButton`
	`372`	`+ }`
	`373`	`+ }`
	`374`	+ </script>`
`351`	`375`	`}`
`352`	`376`	`],`
`353`	`377`	`invalid: [`

Comments

(0)