Commit c931ae6

authored

Fix crash in component-api-style rule (#1721)

1 parent 20eaee7 commit c931ae6Copy full SHA for c931ae6

File tree

+35

-7

lines changed

+35

-7

lines changed

Lines changed: 6 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -274,19 +274,18 @@ module.exports = {`
`274`	`274`	`if (!name) {`
`275`	`275`	`continue`
`276`	`276`	`}`
`277`		`- const propAllowed = apis.some(`
`278`		`- (api) => api.allow && api.options.has(name)`
`279`		`- )`
`280`		`- if (!propAllowed) {`
	`277`	`+ const disallowApi =`
	`278`	`+ !apis.some((api) => api.allow && api.options.has(name)) &&`
	`279`	`+ apis.find((api) => !api.allow && api.options.has(name))`
	`280`	`+`
	`281`	`+ if (disallowApi) {`
`281`	`282`	`context.report({`
`282`	`283`	`node: prop.key,`
`283`	`284`	`messageId: isPreferScriptSetup(allows)`
`284`	`285`	`? 'disallowComponentOptionPreferScriptSetup'`
`285`	`286`	`: 'disallowComponentOption',`
`286`	`287`	`data: {`
`287`		`- disallowedApi: apis.filter(`
`288`		`- (api) => !api.allow && api.options.has(name)`
`289`		`- )[0].apiName,`
	`288`	`+ disallowedApi: disallowApi.apiName,`
`290`	`289`	`optionPhrase: buildOptionPhrase(name),`
`291`	`290`	`allowedApis: buildAllowedPhrase(allows)`
`292`	`291`	`}`

Lines changed: 29 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -181,6 +181,35 @@ tester.run('component-api-style', rule, {`
`181`	`181`	`}`
`182`	`182`	`</script>`
`183`	`183`	`
	`184`	`+ },`
	`185`	`+ {`
	`186`	`+ // https://github.com/vuejs/eslint-plugin-vue/issues/1720`
	`187`	`+ filename: 'test.vue',`
	`188`	`+ options: [['composition']],`
	`189`	+ code: `
	`190`	`+ <template>`
	`191`	`+ <div id="app">`
	`192`	`+ <header>`
	`193`	`+ <Navigation />`
	`194`	`+ </header>`
	`195`	`+ <main class="container-fluid mb-4" role="main">`
	`196`	`+ <RouterView />`
	`197`	`+ </main>`
	`198`	`+ </div>`
	`199`	`+ </template>`
	`200`	`+`
	`201`	`+ <script lang="ts">`
	`202`	`+ import { defineComponent } from '@vue/composition-api'`
	`203`	`+`
	`204`	`+ import Navigation from '@/components/app/nav/Navigation.vue'`
	`205`	`+`
	`206`	`+ export default defineComponent({`
	`207`	`+ name: 'App',`
	`208`	`+ components: {`
	`209`	`+ Navigation,`
	`210`	`+ },`
	`211`	`+ })`
	`212`	+ </script>`
`184`	`213`	`}`
`185`	`214`	`],`
`186`	`215`	`invalid: [`

Comments

(0)