Commit b25be73

armano2mysticatea

authored and

committed

Fix: 'no-shared-component-data' false positive when using arrow functions (fixes #154)(#156)

1 parent 1e7a13a commit b25be73Copy full SHA for b25be73

File tree

2 files changed

+28

-15

lines changed

lib/rules
- no-shared-component-data.js
tests/lib/rules
- no-shared-component-data.js

2 files changed

+28

-15

lines changed

`‎lib/rules/no-shared-component-data.js`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ function create (context) {`
`18`	`18`	`p.key.type === 'Identifier' &&`
`19`	`19`	`p.key.name === 'data' &&`
`20`	`20`	`p.value.type !== 'FunctionExpression' &&`
	`21`	`+ p.value.type !== 'ArrowFunctionExpression' &&`
`21`	`22`	`p.value.type !== 'Identifier'`
`22`	`23`	`)`
`23`	`24`	`.forEach(cp => {`
`@@ -41,9 +42,7 @@ module.exports = {`
`41`	`42`	`recommended: false`
`42`	`43`	`},`
`43`	`44`	`fixable: null, // or "code" or "whitespace"`
`44`		`- schema: [`
`45`		`- // fill in your schema`
`46`		`- ]`
	`45`	`+ schema: []`
`47`	`46`	`},`
`48`	`47`
`49`	`48`	`create`

`‎tests/lib/rules/no-shared-component-data.js`

Lines changed: 26 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,12 @@ const rule = require('../../../lib/rules/no-shared-component-data')`
`12`	`12`
`13`	`13`	`const RuleTester = require('eslint').RuleTester`
`14`	`14`
	`15`	`+const parserOptions = {`
	`16`	`+ ecmaVersion: 7,`
	`17`	`+ sourceType: 'module',`
	`18`	`+ ecmaFeatures: { experimentalObjectRestSpread: true }`
	`19`	`+}`
	`20`	`+`
`15`	`21`	`// ------------------------------------------------------------------------------`
`16`	`22`	`// Tests`
`17`	`23`	`// ------------------------------------------------------------------------------`
`@@ -30,7 +36,8 @@ ruleTester.run('no-shared-component-data', rule, {`
`30`	`36`	`}`
`31`	`37`	`}`
`32`	`38`	`})`
`33`		- `
	`39`	+ `,
	`40`	`+ parserOptions`
`34`	`41`	`},`
`35`	`42`	`{`
`36`	`43`	`filename: 'test.js',`
`@@ -44,11 +51,7 @@ ruleTester.run('no-shared-component-data', rule, {`
`44`	`51`	`}`
`45`	`52`	`})`
`46`	`53`	`,
`47`		`- parserOptions: {`
`48`		`- ecmaVersion: 7,`
`49`		`- sourceType: 'module',`
`50`		`- ecmaFeatures: { experimentalObjectRestSpread: true }`
`51`		`- }`
	`54`	`+ parserOptions`
`52`	`55`	`},`
`53`	`56`	`{`
`54`	`57`	`filename: 'test.js',`
`@@ -71,7 +74,7 @@ ruleTester.run('no-shared-component-data', rule, {`
`71`	`74`	`}`
`72`	`75`	`})`
`73`	`76`	`,
`74`		`- parserOptions: {ecmaVersion: 6}`
	`77`	`+ parserOptions`
`75`	`78`	`},`
`76`	`79`	`{`
`77`	`80`	`filename: 'test.vue',`
`@@ -84,7 +87,7 @@ ruleTester.run('no-shared-component-data', rule, {`
`84`	`87`	`}`
`85`	`88`	`}`
`86`	`89`	`,
`87`		`- parserOptions: {ecmaVersion: 6,sourceType: 'module'}`
	`90`	`+ parserOptions`
`88`	`91`	`},`
`89`	`92`	`{`
`90`	`93`	`filename: 'test.vue',`
`@@ -93,7 +96,7 @@ ruleTester.run('no-shared-component-data', rule, {`
`93`	`96`	`...foo`
`94`	`97`	`}`
`95`	`98`	`,
`96`		`- parserOptions: {ecmaVersion: 6,sourceType: 'module',ecmaFeatures: {experimentalObjectRestSpread: true}}`
	`99`	`+ parserOptions`
`97`	`100`	`},`
`98`	`101`	`{`
`99`	`102`	`filename: 'test.vue',`
`@@ -102,7 +105,18 @@ ruleTester.run('no-shared-component-data', rule, {`
`102`	`105`	`data`
`103`	`106`	`}`
`104`	`107`	`,
`105`		`- parserOptions: { ecmaVersion: 6, sourceType: 'module' }`
	`108`	`+ parserOptions`
	`109`	`+ },`
	`110`	`+ {`
	`111`	`+ filename: 'test.vue',`
	`112`	+ code: `
	`113`	`+ export default {`
	`114`	`+ data: () => {`
	`115`	`+`
	`116`	`+ }`
	`117`	`+ }`
	`118`	+ `,
	`119`	`+ parserOptions`
`106`	`120`	`}`
`107`	`121`	`],`
`108`	`122`
`@@ -116,7 +130,7 @@ ruleTester.run('no-shared-component-data', rule, {`
`116`	`130`	`}`
`117`	`131`	`})`
`118`	`132`	`,
`119`		`- parserOptions: {ecmaVersion: 6},`
	`133`	`+ parserOptions,`
`120`	`134`	`errors: [{`
`121`	`135`	message: '`data` property in component must be a function',
`122`	`136`	`line: 3`
`@@ -131,7 +145,7 @@ ruleTester.run('no-shared-component-data', rule, {`
`131`	`145`	`}`
`132`	`146`	`}`
`133`	`147`	`,
`134`		`- parserOptions: {ecmaVersion: 6,sourceType: 'module'},`
	`148`	`+ parserOptions,`
`135`	`149`	`errors: [{`
`136`	`150`	message: '`data` property in component must be a function',
`137`	`151`	`line: 3`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit b25be73

File tree

2 files changed

2 files changed

`‎lib/rules/no-shared-component-data.js`

`‎tests/lib/rules/no-shared-component-data.js`

0 commit comments