Commit b23c518

authored

Check only left part of assignment in no-side-effects-in-computed-property rule (#231)

1 parent 5f4f3ce commit b23c518Copy full SHA for b23c518

File tree

+22

-2

lines changed

+22

-2

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,9 @@ function create (context) {`
`12`	`12`	`return Object.assign({},`
`13`	`13`	`{`
`14`	`14`	`// this.xxx <=\|+=\|-=>`
`15`		`- 'AssignmentExpression > MemberExpression' (node) {`
`16`		`- if (utils.parseMemberExpression(node)[0] === 'this') {`
	`15`	`+ 'AssignmentExpression' (node) {`
	`16`	`+ if (node.left.type !== 'MemberExpression') return`
	`17`	`+ if (utils.parseMemberExpression(node.left)[0] === 'this') {`
`17`	`18`	`forbiddenNodes.push(node)`
`18`	`19`	`}`
`19`	`20`	`},`

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,18 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {`
`105`	`105`	`}`
`106`	`106`	})`,
`107`	`107`	`parserOptions`
	`108`	`+ },`
	`109`	`+ {`
	`110`	+ code: `Vue.component('test', {
	`111`	`+ computed: {`
	`112`	`+ test () {`
	`113`	`+ let a;`
	`114`	`+ a = this.something`
	`115`	`+ return a`
	`116`	`+ },`
	`117`	`+ }`
	`118`	+ })`,
	`119`	`+ parserOptions`
`108`	`120`	`}`
`109`	`121`	`],`
`110`	`122`	`invalid: [`
`@@ -128,6 +140,10 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {`
`128`	`140`	`const test = this.another.something.push('example')`
`129`	`141`	`return 'something'`
`130`	`142`	`},`
	`143`	`+ test5() {`
	`144`	`+ this.something[index] = thing[index]`
	`145`	`+ return this.something`
	`146`	`+ },`
`131`	`147`	`}`
`132`	`148`	})`,
`133`	`149`	`parserOptions,`
`@@ -146,6 +162,9 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {`
`146`	`162`	`}, {`
`147`	`163`	`line: 17,`
`148`	`164`	`message: 'Unexpected side effect in "test4" computed property.'`
	`165`	`+ }, {`
	`166`	`+ line: 21,`
	`167`	`+ message: 'Unexpected side effect in "test5" computed property.'`
`149`	`168`	`}]`
`150`	`169`	`},`
`151`	`170`	`{`

Comments

(0)