Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit a8c0940

Browse files
authored
test(html-button-has-type): make tests more strict (#2831)
1 parent f0a0830 commit a8c0940

File tree

1 file changed

+58
-16
lines changed

1 file changed

+58
-16
lines changed

‎tests/lib/rules/html-button-has-type.js

Lines changed: 58 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,10 @@ ruleTester.run('html-button-has-type', rule, {
5858
errors: [
5959
{
6060
message: 'Missing an explicit type attribute for button.',
61-
column: 11
61+
column: 11,
62+
line: 1,
63+
endLine: 1,
64+
endColumn: 19
6265
}
6366
]
6467
},
@@ -68,7 +71,10 @@ ruleTester.run('html-button-has-type', rule, {
6871
errors: [
6972
{
7073
message: 'A value must be set for button type attribute.',
71-
column: 24
74+
column: 24,
75+
line: 1,
76+
endLine: 1,
77+
endColumn: 26
7278
}
7379
]
7480
},
@@ -78,7 +84,10 @@ ruleTester.run('html-button-has-type', rule, {
7884
errors: [
7985
{
8086
message: 'A value must be set for button type attribute.',
81-
column: 19
87+
column: 19,
88+
line: 1,
89+
endLine: 1,
90+
endColumn: 23
8291
}
8392
]
8493
},
@@ -88,7 +97,10 @@ ruleTester.run('html-button-has-type', rule, {
8897
errors: [
8998
{
9099
message: 'foo is an invalid value for button type attribute.',
91-
column: 24
100+
column: 24,
101+
line: 1,
102+
endLine: 1,
103+
endColumn: 29
92104
}
93105
]
94106
},
@@ -99,7 +111,10 @@ ruleTester.run('html-button-has-type', rule, {
99111
errors: [
100112
{
101113
message: 'button is a forbidden value for button type attribute.',
102-
column: 24
114+
column: 24,
115+
line: 1,
116+
endLine: 1,
117+
endColumn: 32
103118
}
104119
]
105120
},
@@ -110,7 +125,10 @@ ruleTester.run('html-button-has-type', rule, {
110125
errors: [
111126
{
112127
message: 'submit is a forbidden value for button type attribute.',
113-
column: 24
128+
column: 24,
129+
line: 1,
130+
endLine: 1,
131+
endColumn: 32
114132
}
115133
]
116134
},
@@ -121,7 +139,10 @@ ruleTester.run('html-button-has-type', rule, {
121139
errors: [
122140
{
123141
message: 'reset is a forbidden value for button type attribute.',
124-
column: 24
142+
column: 24,
143+
line: 1,
144+
endLine: 1,
145+
endColumn: 31
125146
}
126147
]
127148
},
@@ -137,17 +158,23 @@ ruleTester.run('html-button-has-type', rule, {
137158
{
138159
message: 'button is a forbidden value for button type attribute.',
139160
line: 2,
140-
column: 30
161+
column: 30,
162+
endLine: 2,
163+
endColumn: 38
141164
},
142165
{
143166
message: 'submit is a forbidden value for button type attribute.',
144167
line: 3,
145-
column: 30
168+
column: 30,
169+
endLine: 3,
170+
endColumn: 38
146171
},
147172
{
148173
message: 'reset is a forbidden value for button type attribute.',
149174
line: 4,
150-
column: 30
175+
column: 30,
176+
endLine: 4,
177+
endColumn: 37
151178
}
152179
]
153180
},
@@ -165,17 +192,23 @@ ruleTester.run('html-button-has-type', rule, {
165192
{
166193
message: 'reset is a forbidden value for button type attribute.',
167194
line: 4,
168-
column: 30
195+
column: 30,
196+
endLine: 4,
197+
endColumn: 37
169198
},
170199
{
171200
message: 'A value must be set for button type attribute.',
172201
line: 5,
173-
column: 30
202+
column: 30,
203+
endLine: 5,
204+
endColumn: 32
174205
},
175206
{
176207
message: 'foo is an invalid value for button type attribute.',
177208
line: 6,
178-
column: 30
209+
column: 30,
210+
endLine: 6,
211+
endColumn: 35
179212
}
180213
]
181214
},
@@ -185,11 +218,17 @@ ruleTester.run('html-button-has-type', rule, {
185218
errors: [
186219
{
187220
message: 'Missing an explicit type attribute for button.',
188-
column: 11
221+
column: 11,
222+
line: 1,
223+
endLine: 1,
224+
endColumn: 19
189225
},
190226
{
191227
message: 'Missing an explicit type attribute for button.',
192-
column: 39
228+
column: 39,
229+
line: 1,
230+
endLine: 1,
231+
endColumn: 47
193232
}
194233
]
195234
},
@@ -199,7 +238,10 @@ ruleTester.run('html-button-has-type', rule, {
199238
errors: [
200239
{
201240
message: 'A value must be set for button type attribute.',
202-
column: 25
241+
column: 25,
242+
line: 1,
243+
endLine: 1,
244+
endColumn: 27
203245
}
204246
]
205247
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /