Commit a5127b0

FrontEndDogFloEdelmannwaynzh

authored

fix(valid-define-options): Allow the use of simple constants (#2920)

Co-authored-by: Flo Edelmann <git@flo-edelmann.de> Co-authored-by: waynzh <waynzh19@gmail.com>

1 parent 64f9880 commit a5127b0Copy full SHA for a5127b0

File tree

+20

-1

lines changed

+20

-1

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,5 @@`
	`1`	`+---`
	`2`	`+'eslint-plugin-vue': minor`
	`3`	`+---`
	`4`	`+`
	`5`	+Changed `vue/valid-define-options` to allow local literal constant references

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,13 @@ module.exports = {`
`93`	`93`	`(def) =>`
`94`	`94`	`def.type !== 'ImportBinding' &&`
`95`	`95`	`utils.inRange(scriptSetup.range, def.name) &&`
`96`		`- !utils.inRange(defineOptions.range, def.name)`
	`96`	`+ !utils.inRange(defineOptions.range, def.name) &&`
	`97`	`+ !(`
	`98`	`+ def.type === 'Variable' &&`
	`99`	`+ def.parent.kind === 'const' &&`
	`100`	`+ def.node.init &&`
	`101`	`+ def.node.init.type === 'Literal'`
	`102`	`+ )`
`97`	`103`	`)`
`98`	`104`	`) {`
`99`	`105`	`if (utils.withinTypeNode(node)) {`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,14 @@ tester.run('valid-define-options', rule, {`
`74`	`74`
`75`	`75`	`defineOptions(def);`
`76`	`76`	</script>`
	`77`	`+ },`
	`78`	`+ {`
	`79`	`+ filename: 'test.vue',`
	`80`	+ code: `
	`81`	`+ <script setup>`
	`82`	`+ const def = 'foo';`
	`83`	`+ defineOptions({ name: def });`
	`84`	+ </script>`
`77`	`85`	`}`
`78`	`86`	`],`
`79`	`87`	`invalid: [`

Comments

(0)