Commit 9fa8ede

authored

Skip conditional expressions in vue/valid-next-tick (#1777)

1 parent 0ca5f9d commit 9fa8edeCopy full SHA for 9fa8ede

File tree

+19

-1

lines changed

+19

-1

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,12 @@ module.exports = {`
`142`	`142`	`return`
`143`	`143`	`}`
`144`	`144`
`145`		`- const parentNode = nextTickNode.parent`
	`145`	`+ let parentNode = nextTickNode.parent`
	`146`	`+`
	`147`	+ // skip conditional expressions like `foo ? nextTick : bar`
	`148`	`+ if (parentNode.type === 'ConditionalExpression') {`
	`149`	`+ parentNode = parentNode.parent`
	`150`	`+ }`
`146`	`151`
`147`	`152`	`if (`
`148`	`153`	`parentNode.type === 'CallExpression' &&`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,19 @@ tester.run('valid-next-tick', rule, {`
`129`	`129`	`},`
`130`	`130`	`}`
`131`	`131`	}</script>`
	`132`	`+ },`
	`133`	`+`
	`134`	`+ // https://github.com/vuejs/eslint-plugin-vue/issues/1776`
	`135`	`+ {`
	`136`	`+ filename: 'test.vue',`
	`137`	+ code: `<script>import { nextTick as nt } from 'vue';
	`138`	`+ export default {`
	`139`	`+ mounted() {`
	`140`	`+ let foo = bar ? nt : undefined;`
	`141`	`+ foo = bar ? Vue.nextTick : undefined;`
	`142`	`+ foo = bar ? this.$nextTick : undefined;`
	`143`	`+ }`
	`144`	+ }</script>`
`132`	`145`	`}`
`133`	`146`	`],`
`134`	`147`	`invalid: [`

Comments

(0)