Commit 8ea98e7

authored

Report missing prop types only for assigned arrays and objects (#318)

1 parent 7faf1a4 commit 8ea98e7Copy full SHA for 8ea98e7

File tree

+21

-1

lines changed

+21

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,9 @@ function create (context) {`
`64`	`64`
`65`	`65`	`if (node.value.type === 'ObjectExpression') {`
`66`	`66`	`checkProperties(node.value.properties)`
`67`		`- } else {`
	`67`	`+ }`
	`68`	`+`
	`69`	`+ if (node.value.type === 'ArrayExpression') {`
`68`	`70`	`context.report({`
`69`	`71`	`node,`
`70`	`72`	`message: 'Props should at least define their types.'`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,24 @@ ruleTester.run('require-prop-types', rule, {`
`69`	`69`	`}`
`70`	`70`	`,
`71`	`71`	`parserOptions: { ecmaVersion: 6, sourceType: 'module' }`
	`72`	`+ },`
	`73`	`+ {`
	`74`	`+ filename: 'test.vue',`
	`75`	+ code: `
	`76`	`+ export default {`
	`77`	`+ props`
	`78`	`+ }`
	`79`	+ `,
	`80`	`+ parserOptions: { ecmaVersion: 6, sourceType: 'module' }`
	`81`	`+ },`
	`82`	`+ {`
	`83`	`+ filename: 'test.vue',`
	`84`	+ code: `
	`85`	`+ export default {`
	`86`	`+ props: externalProps`
	`87`	`+ }`
	`88`	+ `,
	`89`	`+ parserOptions: { ecmaVersion: 6, sourceType: 'module' }`
`72`	`90`	`}`
`73`	`91`	`],`
`74`	`92`

Comments

(0)