Commit 8da7f03

mysticateamichalsnik

authored and

committed

Fix: crash no-v-invalid-v-for on :key (fixes #37) (#39)

1 parent 47532e2 commit 8da7f03Copy full SHA for 8da7f03

File tree

-0

lines changed

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,9 @@ const utils = require('../utils')`
`21`	`21`	* @returns {boolean} `true` if the node is using the variables which are defined by `v-for` directives.
`22`	`22`	`*/`
`23`	`23`	`function isUsingIterationVar (node) {`
	`24`	`+ if (node.value == null) {`
	`25`	`+ return false`
	`26`	`+ }`
`24`	`27`	`const references = node.value.references`
`25`	`28`	`const variables = node.parent.parent.variables`
`26`	`29`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,11 @@ tester.run('no-invalid-v-for', rule, {`
`144`	`144`	`filename: 'test.vue',`
`145`	`145`	`code: '<template><div><custom-component v-for="x in list" :key="foo"></custom-component></div></template>',`
`146`	`146`	`errors: ["Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive."]`
	`147`	`+ },`
	`148`	`+ {`
	`149`	`+ filename: 'test.vue',`
	`150`	`+ code: '<template><div><div v-for="(item, index) in suggestions" :key></div></div></template>',`
	`151`	`+ errors: ["Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive."]`
`147`	`152`	`}`
`148`	`153`	`]`
`149`	`154`	`})`

Comments

(0)