Commit 7664259

authored

Fix false positives for call expression in no-mutating-props rule. (#1584)

1 parent 1c99bcd commit 7664259Copy full SHA for 7664259

File tree

+14

-1

lines changed

+14

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1706,7 +1706,7 @@ module.exports = {`
`1706`	`1706`	`const callName = getStaticPropertyName(mem)`
`1707`	`1707`	`if (`
`1708`	`1708`	`callName &&`
`1709`		`- /^push\|pop\|shift\|unshift\|reverse\|splice\|sort\|copyWithin\|fill$/u.exec(`
	`1709`	`+ /^(?:push\|pop\|shift\|unshift\|reverse\|splice\|sort\|copyWithin\|fill)$/u.exec(`
`1710`	`1710`	`callName`
`1711`	`1711`	`)`
`1712`	`1712`	`) {`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -318,6 +318,19 @@ ruleTester.run('no-mutating-props', rule, {`
`318`	`318`	`value.value++`
`319`	`319`	`</script>`
`320`	`320`	`
	`321`	`+ },`
	`322`	`+ {`
	`323`	`+ // https://github.com/vuejs/eslint-plugin-vue/issues/1579`
	`324`	`+ filename: 'test.vue',`
	`325`	+ code: `
	`326`	`+ <script>`
	`327`	`+ export default {`
	`328`	`+ props: ['prop'],`
	`329`	`+ setup(props) {`
	`330`	`+ props.prop.sortAscending()`
	`331`	`+ }`
	`332`	`+ }`
	`333`	+ </script>`
`321`	`334`	`}`
`322`	`335`	`],`
`323`	`336`

Comments

(0)