Commit 5fc47e5

authored

Fix require-toggle-inside-transition should respect "<slot>", "v-bind:key", attribute "appear" (#2303)

Co-authored-by: williamc <williamc@synology.com>

1 parent 5a29802 commit 5fc47e5Copy full SHA for 5fc47e5

File tree

+23

-1

lines changed

+23

-1

lines changed

Lines changed: 11 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,18 @@ module.exports = {`
`32`	`32`	`if (utils.isCustomComponent(element)) {`
`33`	`33`	`return`
`34`	`34`	`}`
	`35`	`+`
	`36`	`+ /** @type VElement */ // @ts-expect-error`
	`37`	`+ const parent = element.parent`
	`38`	`+ if (utils.hasAttribute(parent, 'appear')) {`
	`39`	`+ return`
	`40`	`+ }`
	`41`	`+`
`35`	`42`	`if (`
	`43`	`+ element.name !== 'slot' &&`
`36`	`44`	`!utils.hasDirective(element, 'if') &&`
`37`		`- !utils.hasDirective(element, 'show')`
	`45`	`+ !utils.hasDirective(element, 'show') &&`
	`46`	`+ !utils.hasDirective(element, 'bind', 'key')`
`38`	`47`	`) {`
`39`	`48`	`context.report({`
`40`	`49`	`node: element.startTag,`
`@@ -51,6 +60,7 @@ module.exports = {`
`51`	`60`	`if (child !== node) {`
`52`	`61`	`return`
`53`	`62`	`}`
	`63`	`+`
`54`	`64`	`verifyInsideElement(node)`
`55`	`65`	`}`
`56`	`66`	`})`

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,18 @@ tester.run('require-toggle-inside-transition', rule, {`
`57`	`57`	`{`
`58`	`58`	`filename: 'test.vue',`
`59`	`59`	`code: '<template><transition><template v-if="show"><div /></template></transition></template>'`
	`60`	`+ },`
	`61`	`+ {`
	`62`	`+ filename: 'test.vue',`
	`63`	`+ code: '<template><transition><slot /></transition></template>'`
	`64`	`+ },`
	`65`	`+ {`
	`66`	`+ filename: 'test.vue',`
	`67`	`+ code: '<template><transition><div :key="k" /></transition></template>'`
	`68`	`+ },`
	`69`	`+ {`
	`70`	`+ filename: 'test.vue',`
	`71`	`+ code: '<template><transition appear><div /></transition></template>'`
`60`	`72`	`}`
`61`	`73`	`],`
`62`	`74`	`invalid: [`

Comments

(0)