Commit 5ec36ce

SysixFloEdelmann

and

authored

feat(no-import-compiler-macros): clarify that macros are not allowed outside <script setup> (#2938)

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

1 parent 3bf079c commit 5ec36ceCopy full SHA for 5ec36ce

File tree

+61

-2

lines changed

+61

-2

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,5 @@`
	`1`	`+---`
	`2`	`+'eslint-plugin-vue': minor`
	`3`	`+---`
	`4`	`+`
	`5`	+Updated `vue/no-import-compiler-macros` to clarify that macros are not allowed outside `<script setup>`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@`
`4`	`4`	`*/`
`5`	`5`	`'use strict'`
`6`	`6`
	`7`	`+const utils = require('../utils')`
	`8`	`+`
`7`	`9`	`const COMPILER_MACROS = new Set([`
`8`	`10`	`'defineProps',`
`9`	`11`	`'defineEmits',`
`@@ -35,7 +37,9 @@ module.exports = {`
`35`	`37`	`schema: [],`
`36`	`38`	`messages: {`
`37`	`39`	`noImportCompilerMacros:`
`38`		`- "'{{name}}' is a compiler macro and doesn't need to be imported."`
	`40`	`+ "'{{name}}' is a compiler macro and doesn't need to be imported.",`
	`41`	`+ onlyValidInScriptSetup:`
	`42`	`+ "'{{name}}' is a compiler macro and can only be used inside <script setup>."`
`39`	`43`	`}`
`40`	`44`	`},`
`41`	`45`	`/**`
`@@ -60,7 +64,9 @@ module.exports = {`
`60`	`64`
`61`	`65`	`context.report({`
`62`	`66`	`node: specifier,`
`63`		`- messageId: 'noImportCompilerMacros',`
	`67`	`+ messageId: utils.isScriptSetup(context)`
	`68`	`+ ? 'noImportCompilerMacros'`
	`69`	`+ : 'onlyValidInScriptSetup',`
`64`	`70`	`data: {`
`65`	`71`	`name: specifier.imported.name`
`66`	`72`	`},`

Lines changed: 48 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,54 @@ tester.run('no-import-compiler-macros', rule, {`
`214`	`214`	`endColumn: 60`
`215`	`215`	`}`
`216`	`216`	`]`
	`217`	`+ },`
	`218`	`+ {`
	`219`	`+ filename: 'test.vue',`
	`220`	+ code: `
	`221`	`+ <script>`
	`222`	`+ // not in <script setup>`
	`223`	`+ import { defineProps } from 'vue'`
	`224`	`+ </script>`
	`225`	+ `,
	`226`	+ output: `
	`227`	`+ <script>`
	`228`	`+ // not in <script setup>`
	`229`	`+`
	`230`	`+ </script>`
	`231`	+ `,
	`232`	`+ errors: [`
	`233`	`+ {`
	`234`	`+ messageId: 'onlyValidInScriptSetup',`
	`235`	`+ data: {`
	`236`	`+ name: 'defineProps'`
	`237`	`+ },`
	`238`	`+ line: 4,`
	`239`	`+ column: 16,`
	`240`	`+ endLine: 4,`
	`241`	`+ endColumn: 27`
	`242`	`+ }`
	`243`	`+ ]`
	`244`	`+ },`
	`245`	`+ {`
	`246`	`+ filename: 'test.ts',`
	`247`	+ code: `
	`248`	`+ import { defineProps } from 'vue'`
	`249`	+ `,
	`250`	+ output: `
	`251`	`+`
	`252`	+ `,
	`253`	`+ errors: [`
	`254`	`+ {`
	`255`	`+ messageId: 'onlyValidInScriptSetup',`
	`256`	`+ data: {`
	`257`	`+ name: 'defineProps'`
	`258`	`+ },`
	`259`	`+ line: 2,`
	`260`	`+ column: 16,`
	`261`	`+ endLine: 2,`
	`262`	`+ endColumn: 27`
	`263`	`+ }`
	`264`	`+ ]`
`217`	`265`	`}`
`218`	`266`	`]`
`219`	`267`	`})`

Comments

(0)