Commit 3ad09ef

waynzhFloEdelmann

and

authored

feat(require-toggle-inside-transition): check directive (#2487)

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

1 parent bfc72a4 commit 3ad09efCopy full SHA for 3ad09ef

File tree

+38

-1

lines changed

+38

-1

lines changed

Lines changed: 19 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,20 @@`
`6`	`6`
`7`	`7`	`const utils = require('../utils')`
`8`	`8`
	`9`	`+/**`
	`10`	`+ * @param {VDirective} vBindAppear`
	`11`	`+ */`
	`12`	`+function isValidBindAppear(vBindAppear) {`
	`13`	`+ if (`
	`14`	`+ vBindAppear.value?.expression &&`
	`15`	`+ vBindAppear.value.expression.type === 'Literal'`
	`16`	`+ ) {`
	`17`	`+ return vBindAppear.value.expression?.value !== false`
	`18`	`+ }`
	`19`	`+`
	`20`	`+ return true`
	`21`	`+}`
	`22`	`+`
`9`	`23`	`module.exports = {`
`10`	`24`	`meta: {`
`11`	`25`	`type: 'problem',`
`@@ -35,7 +49,11 @@ module.exports = {`
`35`	`49`
`36`	`50`	`/** @type VElement */ // @ts-expect-error`
`37`	`51`	`const parent = element.parent`
`38`		`- if (utils.hasAttribute(parent, 'appear')) {`
	`52`	`+ const vBindAppear = utils.getDirective(parent, 'bind', 'appear')`
	`53`	`+ if (`
	`54`	`+ utils.hasAttribute(parent, 'appear') \|\|`
	`55`	`+ (vBindAppear && isValidBindAppear(vBindAppear))`
	`56`	`+ ) {`
`39`	`57`	`return`
`40`	`58`	`}`
`41`	`59`

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,15 @@ tester.run('require-toggle-inside-transition', rule, {`
`68`	`68`	`{`
`69`	`69`	`filename: 'test.vue',`
`70`	`70`	`code: '<template><transition appear><div /></transition></template>'`
	`71`	`+ },`
	`72`	`+ {`
	`73`	`+ // https://github.com/vuejs/eslint-plugin-vue/issues/2467`
	`74`	`+ filename: 'test.vue',`
	`75`	`+ code: '<template><transition :appear="foo"><div /></transition></template>'`
	`76`	`+ },`
	`77`	`+ {`
	`78`	`+ filename: 'test.vue',`
	`79`	`+ code: '<template><transition :appear="true"><div /></transition></template>'`
`71`	`80`	`}`
`72`	`81`	`],`
`73`	`82`	`invalid: [`
`@@ -113,6 +122,16 @@ tester.run('require-toggle-inside-transition', rule, {`
`113`	`122`	`filename: 'test.vue',`
`114`	`123`	`code: '<template><Transition> <div /></Transition></template>',`
`115`	`124`	`errors: [{ messageId: 'expected' }]`
	`125`	`+ },`
	`126`	`+ {`
	`127`	`+ filename: 'test.vue',`
	`128`	`+ code: '<template><transition :appear="false"><div /></transition></template>',`
	`129`	`+ errors: [{ messageId: 'expected' }]`
	`130`	`+ },`
	`131`	`+ {`
	`132`	`+ filename: 'test.vue',`
	`133`	`+ code: '<template><transition @appear="isLoaded"><div /></transition></template>',`
	`134`	`+ errors: [{ messageId: 'expected' }]`
`116`	`135`	`}`
`117`	`136`	`]`
`118`	`137`	`})`

Comments

(0)