Commit 30f94f8

authored

Fix getComputedProperties by allowing object spread inside CP (#465)

1 parent 409fe31 commit 30f94f8Copy full SHA for 30f94f8

File tree

+28

-1

lines changed

+28

-1

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -344,6 +344,7 @@ module.exports = {`
`344`	`344`	`} else if (cp.value.type === 'ObjectExpression') {`
`345`	`345`	`value = cp.value.properties`
`346`	`346`	`.filter(p =>`
	`347`	`+ p.type === 'Property' &&`
`347`	`348`	`p.key.type === 'Identifier' &&`
`348`	`349`	`p.key.name === 'get' &&`
`349`	`350`	`p.value.type === 'FunctionExpression'`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,14 @@ ruleTester.run('no-async-in-computed-properties', rule, {`
`51`	`51`	`return bar`
`52`	`52`	`}`
`53`	`53`	`},`
`54`		`- foo2: {`
	`54`	`+ bar: {`
`55`	`55`	`set () {`
`56`	`56`	`new Promise((resolve, reject) => {})`
`57`	`57`	`}`
	`58`	`+ },`
	`59`	`+ baz: {`
	`60`	`+ ...mapGetters({ get: 'getBaz' }),`
	`61`	`+ ...mapActions({ set: 'setBaz' })`
`58`	`62`	`}`
`59`	`63`	`}`
`60`	`64`	`}`

Lines changed: 22 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,28 @@ describe('getComputedProperties', () => {`
`120`	`120`
`121`	`121`	`assert.ok(computedProperties[0].value)`
`122`	`122`	`})`
	`123`	`+`
	`124`	`+ it('should not collide with object spread operator inside CP', () => {`
	`125`	+ node = parse(`const test = {
	`126`	`+ name: 'test',`
	`127`	`+ computed: {`
	`128`	`+ foo: {`
	`129`	`+ ...mapGetters({ get: 'getFoo' }),`
	`130`	`+ ...mapActions({ set: 'setFoo' })`
	`131`	`+ }`
	`132`	`+ }`
	`133`	+ }`)
	`134`	`+`
	`135`	`+ const computedProperties = utils.getComputedProperties(node)`
	`136`	`+`
	`137`	`+ assert.equal(`
	`138`	`+ computedProperties.length,`
	`139`	`+ 1,`
	`140`	`+ 'it detects all computed properties'`
	`141`	`+ )`
	`142`	`+`
	`143`	`+ assert.notOk(computedProperties[0].value)`
	`144`	`+ })`
`123`	`145`	`})`
`124`	`146`
`125`	`147`	`describe('getStaticPropertyName', () => {`

Comments

(0)