Commit 2a1c654

committed

feature: remove autoFixToSeparateInterface option

1 parent bbdc134 commit 2a1c654Copy full SHA for 2a1c654

File tree

2 files changed

-50

lines changed

lib/rules
- define-props-declaration.js
tests/lib/rules
- define-props-declaration.js

2 files changed

-50

lines changed

`‎lib/rules/define-props-declaration.js`

Lines changed: 1 addition & 25 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,6 @@ const PROPS_SEPARATOR = ', '`
`16`	`16`	`*/`
`17`	`17`	`function* fixTypeBased(fixer, node, props, context) {`
`18`	`18`	`const sourceCode = context.getSourceCode()`
`19`		`- const autoFixToSeparateInterface =`
`20`		`- context.options[1]?.autoFixToSeparateInterface \|\| false`
`21`	`19`
`22`	`20`	`const componentPropsData = props.map((prop) =>`
`23`	`21`	`getComponentPropData(prop, sourceCode)`
`@@ -36,20 +34,7 @@ function* fixTypeBased(fixer, node, props, context) {`
`36`	`34`	`yield fixer.replaceText(node.arguments[0], '')`
`37`	`35`
`38`	`36`	`// add type annotation`
`39`		`- if (autoFixToSeparateInterface) {`
`40`		`- const variableDeclarationNode = node.parent.parent`
`41`		`- if (!variableDeclarationNode) {`
`42`		`- return`
`43`		`- }`
`44`		`-`
`45`		`- yield fixer.insertTextBefore(`
`46`		`- variableDeclarationNode,`
`47`		- `interface Props ${componentPropsTypeCode.replace(/;/g, ',')}; `
`48`		`- )`
`49`		- yield fixer.insertTextAfter(node.callee, `<Props>`)
`50`		`- } else {`
`51`		- yield fixer.insertTextAfter(node.callee, `<${componentPropsTypeCode}>`)
`52`		`- }`
	`37`	+ yield fixer.insertTextAfter(node.callee, `<${componentPropsTypeCode}>`)
`53`	`38`
`54`	`39`	`// add defaults if needed`
`55`	`40`	`const propTypesDataWithDefaultValue = componentPropsData.filter(`
`@@ -242,15 +227,6 @@ module.exports = {`
`242`	`227`	`schema: [`
`243`	`228`	`{`
`244`	`229`	`enum: ['type-based', 'runtime']`
`245`		`- },`
`246`		`- {`
`247`		`- type: 'object',`
`248`		`- properties: {`
`249`		`- autoFixToSeparateInterface: {`
`250`		`- type: 'boolean',`
`251`		`- default: false`
`252`		`- }`
`253`		`- }`
`254`	`230`	`}`
`255`	`231`	`],`
`256`	`232`	`messages: {`

`‎tests/lib/rules/define-props-declaration.js`

Lines changed: 0 additions & 25 deletions

Original file line number	Diff line number	Diff line change
`@@ -538,31 +538,6 @@ tester.run('define-props-declaration', rule, {`
`538`	`538`	`}`
`539`	`539`	`]`
`540`	`540`	`},`
`541`		`- // separate interface`
`542`		`- {`
`543`		`- filename: 'test.vue',`
`544`		- code: `
`545`		`- <script setup lang="ts">`
`546`		`- const props = defineProps({`
`547`		`- kind: {`
`548`		`- type: Object as PropType<{ id: number; name: string }>`
`549`		`- }`
`550`		`- })`
`551`		`- </script>`
`552`		- `,
`553`		- output: `
`554`		`- <script setup lang="ts">`
`555`		`- interface Props { kind?: { id: number, name: string } }; const props = defineProps<Props>()`
`556`		`- </script>`
`557`		- `,
`558`		`- options: ['type-based', { autoFixToSeparateInterface: true }],`
`559`		`- errors: [`
`560`		`- {`
`561`		`- message: 'Use type-based declaration instead of runtime declaration.',`
`562`		`- line: 3`
`563`		`- }`
`564`		`- ]`
`565`		`- },`
`566`	`541`	`// Array of types`
`567`	`542`	`{`
`568`	`543`	`filename: 'test.vue',`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 2a1c654

File tree

2 files changed

2 files changed

`‎lib/rules/define-props-declaration.js`

`‎tests/lib/rules/define-props-declaration.js`

0 commit comments