Commit 164b2ae

armano2michalsnik

authored and

committed

Fix small mistake in require-valid-default-prop (#143)

* Fix small mistakes in `require-valid-default-prop` - Improve coverage for FunctionExpression and ArrowFunctionExpression - Fix traversing over many types (return -> continue) * Cleanup code

1 parent a1fd26b commit 164b2aeCopy full SHA for 164b2ae

File tree

2 files changed

-8

lines changed

lib/rules
- require-valid-default-prop.js
tests/lib/rules
- require-valid-default-prop.js

2 files changed

-8

lines changed

`‎lib/rules/require-valid-default-prop.js`

Lines changed: 5 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -102,23 +102,20 @@ module.exports = {`
`102`	`102`
`103`	`103`	`for (const prop of properties) {`
`104`	`104`	`const type = getPropertyNode(prop.value, 'type')`
`105`		`- if (!type) {`
`106`		`- return`
`107`		`- }`
	`105`	`+ if (!type) continue`
`108`	`106`
`109`	`107`	`const typeNames = new Set(getTypes(type.value)`
`110`	`108`	`.map(item => item === 'Object' \|\| item === 'Array' ? 'Function' : item) // Object and Array require function`
`111`	`109`	`.filter(item => NATIVE_TYPES.has(item)))`
`112`	`110`
`113`		`- if (typeNames.size === 0) { // There is no native types detected`
`114`		`- return`
`115`		`- }`
	`111`	`+ // There is no native types detected`
	`112`	`+ if (typeNames.size === 0) continue`
`116`	`113`
`117`	`114`	`const def = getPropertyNode(prop.value, 'default')`
`118`		`- if (!def) return`
	`115`	`+ if (!def) continue`
`119`	`116`
`120`	`117`	`const defType = getValueType(def.value)`
`121`		`- if (typeNames.has(defType)) return`
	`118`	`+ if (!defType\|\|typeNames.has(defType)) continue`
`122`	`119`
`123`	`120`	`context.report({`
`124`	`121`	`node: def,`

`‎tests/lib/rules/require-valid-default-prop.js`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ ruleTester.run('require-valid-default-prop', rule, {`
`65`	`65`	`foo: null,`
`66`	`66`	`foo: Number,`
`67`	`67`	`foo: [String, Number],`
	`68`	`+ foo: { type: Number, default: VAR_BAR },`
`68`	`69`	`foo: { type: Number, default: 100 },`
`69`	`70`	`foo: { type: [String, Number], default: '' },`
`70`	`71`	`foo: { type: [String, Number], default: 0 },`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 164b2ae

File tree

2 files changed

2 files changed

`‎lib/rules/require-valid-default-prop.js`

`‎tests/lib/rules/require-valid-default-prop.js`

0 commit comments