Commit 07a7d9f

armano2michalsnik

authored and

committed

Fix: multiline-html-element-content-newline case sensitivity (#663)

* Fix: multiline-html-element-content-newline case sensitivity fix issue #662 * fix typo in tests

1 parent 5da94e1 commit 07a7d9fCopy full SHA for 07a7d9f

File tree

2 files changed

+43

-4

lines changed

lib/rules
- multiline-html-element-content-newline.js
tests/lib/rules
- multiline-html-element-content-newline.js

2 files changed

+43

-4

lines changed

`‎lib/rules/multiline-html-element-content-newline.js‎`

Lines changed: 10 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`// ------------------------------------------------------------------------------`
`10`	`10`
`11`	`11`	`const utils = require('../utils')`
	`12`	`+const casing = require('../utils/casing')`
`12`	`13`
`13`	`14`	`// ------------------------------------------------------------------------------`
`14`	`15`	`// Helpers`
`@@ -20,7 +21,7 @@ function isMultilineElement (element) {`
`20`	`21`
`21`	`22`	`function parseOptions (options) {`
`22`	`23`	`return Object.assign({`
`23`		`- 'ignores': ['pre', 'textarea']`
	`24`	`+ ignores: ['pre', 'textarea']`
`24`	`25`	`}, options)`
`25`	`26`	`}`
`26`	`27`
`@@ -80,12 +81,18 @@ module.exports = {`
`80`	`81`
`81`	`82`	`let inIgnoreElement`
`82`	`83`
	`84`	`+ function isIgnoredElement (node) {`
	`85`	`+ return ignores.includes(node.name) \|\|`
	`86`	`+ ignores.includes(casing.pascalCase(node.rawName)) \|\|`
	`87`	`+ ignores.includes(casing.kebabCase(node.rawName))`
	`88`	`+ }`
	`89`	`+`
`83`	`90`	`return utils.defineTemplateBodyVisitor(context, {`
`84`	`91`	`'VElement' (node) {`
`85`	`92`	`if (inIgnoreElement) {`
`86`	`93`	`return`
`87`	`94`	`}`
`88`		`- if (ignores.indexOf(node.name)>=0) {`
	`95`	`+ if (isIgnoredElement(node)) {`
`89`	`96`	`// ignore element name`
`90`	`97`	`inIgnoreElement = node`
`91`	`98`	`return`
`@@ -114,7 +121,7 @@ module.exports = {`
`114`	`121`	`},`
`115`	`122`	`messageId: 'unexpectedAfterClosingBracket',`
`116`	`123`	`data: {`
`117`		`- name: node.name,`
	`124`	`+ name: node.rawName,`
`118`	`125`	`actual: getPhrase(beforeLineBreaks)`
`119`	`126`	`},`
`120`	`127`	`fix (fixer) {`

`‎tests/lib/rules/multiline-html-element-content-newline.js‎`

Lines changed: 33 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -91,13 +91,45 @@ tester.run('multiline-html-element-content-newline', rule, {`
`91`	`91`	`>content</ignore-tag>`
`92`	`92`	`<ignore-tag><div`
`93`	`93`	`>content</div></ignore-tag>`
`94`		`- <ignore-tag>>content`
	`94`	`+ <ignore-tag>content`
`95`	`95`	`content</ignore-tag>`
`96`	`96`	</template>`,
`97`	`97`	`options: [{`
`98`	`98`	`ignores: ['ignore-tag']`
`99`	`99`	`}]`
`100`	`100`	`},`
	`101`	`+ {`
	`102`	+ code: `
	`103`	`+ <template>`
	`104`	`+ <IgnoreTag>content</IgnoreTag>`
	`105`	`+ <IgnoreTag`
	`106`	`+ id="test-pre"`
	`107`	`+ >content</IgnoreTag>`
	`108`	`+ <IgnoreTag><div`
	`109`	`+ >content</div></IgnoreTag>`
	`110`	`+ <IgnoreTag>content`
	`111`	`+ content</IgnoreTag>`
	`112`	+ </template>`,
	`113`	`+ options: [{`
	`114`	`+ ignores: ['IgnoreTag']`
	`115`	`+ }]`
	`116`	`+ },`
	`117`	`+ {`
	`118`	+ code: `
	`119`	`+ <template>`
	`120`	`+ <ignore-tag>content</ignore-tag>`
	`121`	`+ <ignore-tag`
	`122`	`+ id="test-pre"`
	`123`	`+ >content</ignore-tag>`
	`124`	`+ <ignore-tag><div`
	`125`	`+ >content</div></ignore-tag>`
	`126`	`+ <ignore-tag>content`
	`127`	`+ content</ignore-tag>`
	`128`	+ </template>`,
	`129`	`+ options: [{`
	`130`	`+ ignores: ['IgnoreTag']`
	`131`	`+ }]`
	`132`	`+ },`
`101`	`133`	`// Ignore if no closing brackets`
`102`	`134`	`
`103`	`135`	`<template>`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 07a7d9f

File tree

2 files changed

2 files changed

`‎lib/rules/multiline-html-element-content-newline.js‎`

`‎tests/lib/rules/multiline-html-element-content-newline.js‎`

0 commit comments