Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Playwright webserver command should run build before preview? #263

Open
@vincerubinetti

Description

Currently, create-vue generates a playwright config that has something like this in it:

{
 webServer: {
 /**
 * use the dev server by default for faster feedback loop. Use the preview
 * server on CI for more realistic testing
 */
 command: process.env.CI
 ? "vite preview --port 5173"
 : "vite dev",
 port: 5173,
 reuseExistingServer: !process.env.CI,
 }
}

Shouldn't we need to run build before preview so that the app actually exists?

I ran into problems running my tests on GitHub Actions, and it took me a while to figure out that this was the cause. See:
vitejs/vite#4572

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /