Commit b15112b

authored

Merge pull request #538 from pacopage/master

Fix required number input does not require a value

2 parents 2550336 + f95b38c commit b15112bCopy full SHA for b15112b

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { defaults, isNil, isNumber, isInteger, isString, isArray, isFunction } from "lodash";`
	`1`	`+import { defaults, isNil, isNumber, isInteger, isString, isArray, isFunction,isFinite } from "lodash";`
`2`	`2`	`import fecha from "fecha";`
`3`	`3`
`4`	`4`	`let resources = {`
`@@ -66,7 +66,7 @@ const validators = {`
`66`	`66`	`if (res != null) return res;`
`67`	`67`
`68`	`68`	`let err = [];`
`69`		`- if (isNumber(value)) {`
	`69`	`+ if (isFinite(value)) {`
`70`	`70`	`if (!isNil(field.min) && value < field.min) {`
`71`	`71`	`err.push(msg(messages.numberTooSmall, field.min));`
`72`	`72`	`}`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,12 @@ describe("Validators", () => {`
`31`	`31`	`check(v.number, null, field, 1);`
`32`	`32`	`});`
`33`	`33`
	`34`	`+ it("should give error if value is NaN or Infinity", () => {`
	`35`	`+ check(v.number, NaN, field, 1);`
	`36`	`+ check(v.number, Infinity, field, 1);`
	`37`	`+ check(v.number, -Infinity, field, 1);`
	`38`	`+ });`
	`39`	`+`
`34`	`40`	`it("should give error if value is smaller than min", () => {`
`35`	`41`	`check(v.number, -1, field, 1);`
`36`	`42`	`check(v.number, 0, field, 1);`
`@@ -68,7 +74,7 @@ describe("Validators", () => {`
`68`	`74`	`// invalid integer`
`69`	`75`	`check(v.integer, 3.14, field, 1);`
`70`	`76`	`// invalid number, invalid integer`
`71`		`- check(v.integer, "3.14", field, 2);`
	`77`	`+ check(v.integer, NaN, field, 2);`
`72`	`78`	`});`
`73`	`79`
`74`	`80`	`it("should not give error if value is integer", () => {`

Comments

(0)