Commit 3d2e821

committed

🐛 Fix options prop default #91

1 parent a40e23c commit 3d2e821Copy full SHA for 3d2e821

File tree

2 files changed

+60

-9

lines changed

src
- formGenerator.vue
test/unit/specs
- VueFormGenerator.spec.js

2 files changed

+60

-9

lines changed

`‎src/formGenerator.vue`

Lines changed: 26 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,13 +32,31 @@ div`
`32`	`32`	`export default {`
`33`	`33`	`components: fieldComponents,`
`34`	`34`
`35`		`- props: [`
`36`		`- "schema",`
`37`		`- "options",`
`38`		`- "model",`
`39`		`- "multiple",`
`40`		`- "isNewModel"`
`41`		`- ],`
	`35`	`+ props: {`
	`36`	`+ schema: Object,`
	`37`	`+`
	`38`	`+ model: Object,`
	`39`	`+`
	`40`	`+ options: {`
	`41`	`+ type: Object,`
	`42`	`+ default() {`
	`43`	`+ return {`
	`44`	`+ validateAfterLoad: false,`
	`45`	`+ validateAfterChanged: false`
	`46`	`+ }`
	`47`	`+ }`
	`48`	`+ },`
	`49`	`+`
	`50`	`+ multiple: {`
	`51`	`+ type: Boolean,`
	`52`	`+ default: false`
	`53`	`+ },`
	`54`	`+`
	`55`	`+ isNewModel: {`
	`56`	`+ type: Boolean,`
	`57`	`+ default: false`
	`58`	`+ }`
	`59`	`+ },`
`42`	`60`
`43`	`61`	`data () {`
`44`	`62`	`return {`
`@@ -76,7 +94,7 @@ div`
`76`	`94`
`77`	`95`	`compiled() {`
`78`	`96`	`// First load, running validation if neccessary`
`79`		`- if (this.options&&this.options.validateAfterLoad === true && this.isNewModel !== true)`
	`97`	`+ if (this.options.validateAfterLoad === true && this.isNewModel !== true)`
`80`	`98`	`this.validate();`
`81`	`99`	`else`
`82`	`100`	`this.clearValidationErrors();`

`‎test/unit/specs/VueFormGenerator.spec.js`

Lines changed: 34 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ Vue.use(VueFormGenerator);`
`7`	`7`
`8`	`8`	`let el, vm;`
`9`	`9`
`10`		`-function createFormGenerator(schema = {}, model = null, options={}, multiple=false) {`
	`10`	`+function createFormGenerator(schema = {}, model = null, options, multiple) {`
`11`	`11`	`el = document.createElement("div");`
`12`	`12`	`// eslint-disable-next-line quotes`
`13`	`13`	el.innerHTML = `<vue-form-generator :schema="schema" :model="model" :options="options" :multiple="multiple" v-ref:form></vue-form-generator>`;
`@@ -414,6 +414,39 @@ describe("VueFormGenerator.vue", () => {`
`414`	`414`
`415`	`415`	`});`
`416`	`416`
	`417`	`+ describe("check if option null", () => {`
	`418`	`+ let schema = {`
	`419`	`+ fields: [`
	`420`	`+ {`
	`421`	`+ type: "text",`
	`422`	`+ label: "Name",`
	`423`	`+ model: "name"`
	`424`	`+ }`
	`425`	`+ ]`
	`426`	`+ };`
	`427`	`+`
	`428`	`+ let model = { name: "Me" };`
	`429`	`+ let form, el, vm;`
	`430`	`+`
	`431`	`+ before( () => {`
	`432`	`+ [el, vm] = createFormGenerator(schema, model);`
	`433`	`+ form = vm.$refs.form;`
	`434`	`+ document.body.appendChild(el);`
	`435`	`+ });`
	`436`	`+`
	`437`	`+ after( () => {`
	`438`	`+ document.body.removeChild(el);`
	`439`	`+ });`
	`440`	`+`
	`441`	`+ it("should be validation error at ready()", (done) => {`
	`442`	`+ vm.$nextTick( () => {`
	`443`	`+ expect(form).to.be.defined;`
	`444`	`+ expect(form.options).to.be.defined;`
	`445`	`+ done();`
	`446`	`+ });`
	`447`	`+ });`
	`448`	`+ });`
	`449`	`+`
`417`	`450`	`describe("check validateAfterLoad option", () => {`
`418`	`451`	`let schema = {`
`419`	`452`	`fields: [`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 3d2e821

File tree

2 files changed

2 files changed

`‎src/formGenerator.vue`

`‎test/unit/specs/VueFormGenerator.spec.js`

0 commit comments