Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit f983c58

Browse files
fix: resolveClosed dynamicModals first
1 parent 535704d commit f983c58

File tree

5 files changed

+3
-1
lines changed

5 files changed

+3
-1
lines changed

‎packages/vue-final-modal/cypress.config.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import { defineConfig } from 'cypress'
22

33
export default defineConfig({
44
component: {
5+
video: false,
6+
screenshotOnRunFailure: false,
57
specPattern: 'cypress/components/**/*.spec.ts',
68
devServer: {
79
framework: 'vue',
Binary file not shown.
Binary file not shown.
Binary file not shown.

‎packages/vue-final-modal/src/plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,9 @@ function createInternalVfm(vfm: Vfm) {
9393
}
9494
},
9595
resolvedClosed(index: number) {
96+
dynamicModals[index]?.resolveClosed?.()
9697
if (!dynamicModals[index].keepAlive)
9798
dynamicModals.splice(index, 1)
98-
dynamicModals[index]?.resolveClosed?.()
9999
},
100100
resolvedOpened(index: number) {
101101
dynamicModals[index]?.resolveOpened?.()

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /