-
Notifications
You must be signed in to change notification settings - Fork 0
[codec][P2/P3] Hygiene: --locked, toolchain pin, brotli-wasm pin, engines, crates.io, dead variants #18
Open
Description
Re-audit 2026年05月29日 (PR #7). Opportunistic hardening; none block merge.
- CI cargo build/test omit
--locked(ci.yml:27) — committed Cargo.lock not enforced. rust-toolchain.toml(1.85.0) not honored in CI — floatingstableused (ci.yml).- rust-cache emits "could not find Cargo.toml" exit-101 ×ばつ2 at workspace root (
ci.yml:19) — non-fatal, disables caching + masks signal. brotli-wasm ^3.0.1unpinned → wire-byte determinism risk for a perpetual codec (receiptHash safe; wire URLs not).engines.node >=24(codec) vs>=18(types/networks/brotli-wasm) — narrows adoption with no stated reason.- PF-3 crates.io reserve + Rust crate publishability (
cargo publish --dry-run, license-file, excluded test/vector bloat) unverified. - 3 dead
CodecErrorvariants (SignatureInvalid, DictionaryMismatch, CompressionFailed); salt-length/missing-salt reported as ChecksumMismatch (taxonomy overlap). - WASM gzip ~95.7% of locked 80KB cap (~3.5KB headroom) — watch.
- Token-list liveness in a 'perpetual' surface:
tokens.tslogoURI → UniswapmasterCDN;chains.tsrpcUrls[0] → llamarpc. - 4 dead golden vectors (loaded by no test);
malformed-non-canonical-varintvector hits the Overflow path, not the non-canonical-varint branch it claims (vectors/v4-codec.json).
Source: 43-agent audit dimensions + completeness critic.
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.