Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 6170388

Browse files
author
vinogradov
committed
update dependencies, add pre-push git hook, add max-len eslint rule (pretty opinionated but makes sense in most cases)
1 parent acfffa6 commit 6170388

File tree

4 files changed

+110
-84
lines changed

4 files changed

+110
-84
lines changed

‎.eslintrc.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ module.exports = {
77
'object-curly-spacing': ['warn', 'never'],
88
'comma-dangle': ['warn', 'never'],
99
'max-len': ['warn', 120],
10-
'react/jsx-filename-extension': ['off']
10+
'react/jsx-filename-extension': ['off'],
11+
'max-lines': ['warn', {max: 600, skipBlankLines: true, skipComments: true}]
1112
}
1213
};

‎README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
[See in action](https://vinogradov.github.io/react-starter-kit)
22

3-
Includes only the latest and greatest web technologies (dependencies updated at May 30 2017). Use it for your next heroic SPA project because you can't go wrong with it. Contains minimal viable "hello, world" code just to proof it works. Remove hello world and write your own great project.
3+
Includes only the latest and greatest web technologies (dependencies updated at 8 June 2017). Use it for your next heroic SPA project because you can't go wrong with it. Contains minimal viable "hello, world" code just to proof it works. Remove hello world and write your own great project.
44

55
# Principles
6-
1. Use plain [ES2015](https://babeljs.io/docs/plugins/preset-es2015/)/[16](https://babeljs.io/docs/plugins/preset-es2016/)/[17](https://babeljs.io/docs/plugins/preset-es2017/). Minimize use of [experimental Stage-X](https://babeljs.io/docs/plugins/#presets-stage-x-experimental-presets-) javascript features. Only [stage-3](https://babeljs.io/docs/plugins/preset-stage-3/)/4 features are supported, because they're relatively stable
7-
1. Use tests (by [jest](https://github.com/facebook/jest), [example](https://github.com/vinogradov/react-starter-kit/blob/master/src/examples/react/__tests__/hello.test.js))
8-
1. Use linting (by [airbnb eslint config](https://github.com/airbnb/javascript))
6+
1. Using plain [ES2015](https://babeljs.io/docs/plugins/preset-es2015/)/[16](https://babeljs.io/docs/plugins/preset-es2016/)/[17](https://babeljs.io/docs/plugins/preset-es2017/). Minimizing use of [experimental Stage-X](https://babeljs.io/docs/plugins/#presets-stage-x-experimental-presets-) javascript features. Only [stage-3](https://babeljs.io/docs/plugins/preset-stage-3/)/4 features are supported, because they're relatively stable
7+
1. Using tests (by [jest](https://github.com/facebook/jest), [example](https://github.com/vinogradov/react-starter-kit/blob/master/src/examples/react/__tests__/hello.test.js))
8+
1. Using linting (by [airbnb eslint config](https://github.com/airbnb/javascript))
9+
1. Using git [pre-push hook](https://git-scm.com/book/gr/v2/Customizing-Git-Git-Hooks) to force run tests and linting before push
910

1011
# Suitable for
1112
1. Education

‎package.json

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
"start": "webpack-dev-server",
88
"dist": "webpack --display-error-details --env.dist",
99
"test": "jest src",
10-
"lint": "eslint .; eslint --no-ignore --config .eslintrc.js --config .eslintrc-test.js --ext test.js ."
10+
"lint": "eslint . && eslint --no-ignore --config .eslintrc.js --config .eslintrc-test.js --ext test.js .",
11+
"prepush": "yarn test && yarn lint"
1112
},
1213
"license": "MIT",
1314
"dependencies": {
@@ -28,8 +29,8 @@
2829
"eslint-plugin-jest": "20.0.3",
2930
"eslint-plugin-jsx-a11y": "5.0.3",
3031
"eslint-plugin-react": "7.0.1",
31-
"extract-text-webpack-plugin": "2.1.0",
32-
"file-loader": "0.11.1",
32+
"extract-text-webpack-plugin": "2.1.2",
33+
"file-loader": "0.11.2",
3334
"html-webpack-plugin": "2.28.0",
3435
"isomorphic-fetch": "2.2.1",
3536
"jest": "20.0.4",
@@ -45,10 +46,11 @@
4546
"redux-saga": "0.15.3",
4647
"redux-thunk": "2.2.0",
4748
"sass-loader": "6.0.5",
48-
"style-loader": "0.18.1",
49+
"style-loader": "0.18.2",
4950
"webpack": "2.6.1"
5051
},
5152
"devDependencies": {
53+
"husky": "0.13.4",
5254
"webpack-dev-server": "2.4.5"
5355
},
5456
"engines": {

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /