Commit ddedaea

authored

Merge pull request #128 from lenka-krippnerova/slavic-blocks

Update Slavic blocks

2 parents fc180b9 + 7841d88 commit ddedaeaCopy full SHA for ddedaea

File tree

3 files changed

-3

lines changed

udapi/block/msf
- phrase.py
- slavic
  - past.py
  - preprocessor.py

3 files changed

-3

lines changed

`‎udapi/block/msf/phrase.py`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,8 @@ def get_polarity(self, node, neg):`
`59`	`59`	`return 'Neg'`
`60`	`60`
`61`	`61`	`def get_is_reflex(self,node,refl):`
	`62`	`+ if node.feats['Voice'] == 'Mid':`
	`63`	`+ return 'Yes'`
`62`	`64`	`if len(refl) == 0:`
`63`	`65`	`return node.feats['Reflex']`
`64`	`66`	`return 'Yes'`

`‎udapi/block/msf/slavic/past.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ def process_node(self, node):`
`39`	`39`	`person=node.feats['Person'],`
`40`	`40`	`number=node.feats['Number'],`
`41`	`41`	`mood=node.feats['Mood'],`
`42`		`- voice='Pass',`
	`42`	`+ voice='Act', #In Polish, impersonal statements are annotated with Voice=Act. In Ukrainian, the Voice feature is missing; therefore, we decided to annotate these phrases with PhraseVoice=Act`
`43`	`43`	`aspect=node.feats['Aspect'],`
`44`	`44`	`form=node.feats['VerbForm'],`
`45`	`45`	`polarity=self.get_polarity(node,neg),`

`‎udapi/block/msf/slavic/preprocessor.py`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,7 @@ def process_node(self,node):`
`31`	`31`	`# In Ukrainian, there is no explicit annotation of reflexive verbs`
`32`	`32`	`# We decided to unify the annotation of reflexive verbs with Russian and Belarusian, where reflexive verbs are formed similarly`
`33`	`33`	`# We add the feature Voice=Mid to reflexive verbs`
`34`		`- # This feature is added only to Ukrainian data (for example, there are some verbs in Old Church Slavonic that end in 'сь' but are not reflexive)`
`35`		`- if node.upos == 'VERB' and (node.form.endswith('сь') or node.form.endswith('ся')) and self.lang == 'uk':`
	`34`	`+ if node.upos == 'VERB' and (node.lemma.endswith('сь') or node.lemma.endswith('ся')):`
`36`	`35`	`node.feats['Voice'] = 'Mid'`
`37`	`36`
`38`	`37`	`# makedonstina tvori budouci cas pomoci pomocneho slova ќе, u nejz neni nijak vyznaceno, ze se podili na tvorbe budouciho casu`
`@@ -72,5 +71,9 @@ def process_node(self,node):`
`72`	`71`	`if node.feats['Mood'] == 'Sub':`
`73`	`72`	`node.feats['Mood'] = 'Cnd'`
`74`	`73`
	`74`	`+ # # although infinitives in Old Church Slavonic are annotated with Tense=Pres, they do not convey tense; therefore, we remove this annotation`
	`75`	`+ if node.feats['VerbForm'] == 'Inf':`
	`76`	`+ node.feats['Tense'] = ''`
	`77`	`+`
`75`	`78`	`# TODO maybe we want to set Tense=Fut for the perfective verbs with Tense=Pres? This could solve the problem with the simplified detection of the future tense in Czech`
`76`	`79`	`# but there are many verbs with no Aspect value, so the problem is still there`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit ddedaea

File tree

3 files changed

3 files changed

`‎udapi/block/msf/phrase.py`

`‎udapi/block/msf/slavic/past.py`

`‎udapi/block/msf/slavic/preprocessor.py`

0 commit comments