Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit c6da956

Browse files
refactor(sumOfARange): improved conditions
1 parent 5508109 commit c6da956

File tree

1 file changed

+13
-16
lines changed

1 file changed

+13
-16
lines changed

‎chapters/chapter4/sumOfARange.js

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,13 @@
1-
// Part 1
2-
const range = (start, end, step = 1) => {
1+
export const range = (start, end, step) => {
32
const numbers = []
4-
const interval = Math.abs(step)
3+
const interval = Math.abs(step)||1
54

6-
if (!step) return []
5+
if (start < end && step <= 0) return []
6+
if (start > end && step >= 0) return []
77

8-
if (step > 0) {
9-
if (start < end) {
10-
for (let i = start; i <= end; i += interval) {
11-
numbers.push(i)
12-
}
13-
} else {
14-
for (let i = end; i >= start; i -= interval) {
15-
numbers.push(i)
16-
}
8+
if (start < end) {
9+
for (let i = start; i <= end; i += interval) {
10+
numbers.push(i)
1711
}
1812
} else {
1913
for (let i = start; i >= end; i -= interval) {
@@ -24,7 +18,10 @@ const range = (start, end, step = 1) => {
2418
return numbers
2519
}
2620

27-
// Part 2
28-
constsum=numbers =>numbers.reduce((accum,current)=>accum+current,0)
21+
exportconstsum=numbers=>{
22+
if(typeofnumbers ==='number')returnnumbers
2923

30-
console.log(sum(range(1, 10))) // => 55
24+
return Array.isArray(numbers)
25+
? numbers.reduce((accum, current) => accum + current, 0)
26+
: null
27+
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /