Commit 2a7516f

committed

abort setting state when component got unmounted

1 parent 4d3bb1c commit 2a7516fCopy full SHA for 2a7516f

File tree

+12

-2

lines changed

+12

-2

lines changed

Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,19 +39,29 @@ const useDataApi = (initialUrl, initialData) => {`
`39`	`39`	`});`
`40`	`40`
`41`	`41`	`useEffect(() => {`
	`42`	`+ let didCancel = false;`
	`43`	`+`
`42`	`44`	`const fetchData = async () => {`
`43`	`45`	`dispatch({ type: 'FETCH_INIT' });`
`44`	`46`
`45`	`47`	`try {`
`46`	`48`	`const result = await axios(url);`
`47`	`49`
`48`		`- dispatch({ type: 'FETCH_SUCCESS', payload: result.data });`
	`50`	`+ if (!didCancel) {`
	`51`	`+ dispatch({ type: 'FETCH_SUCCESS', payload: result.data });`
	`52`	`+ }`
`49`	`53`	`} catch (error) {`
`50`		`- dispatch({ type: 'FETCH_FAILURE' });`
	`54`	`+ if (!didCancel) {`
	`55`	`+ dispatch({ type: 'FETCH_FAILURE' });`
	`56`	`+ }`
`51`	`57`	`}`
`52`	`58`	`};`
`53`	`59`
`54`	`60`	`fetchData();`
	`61`	`+`
	`62`	`+ return () => {`
	`63`	`+ didCancel = true;`
	`64`	`+ };`
`55`	`65`	`}, [url]);`
`56`	`66`
`57`	`67`	`const doGet = (event, url) => {`

Comments

(0)