Commit d8a2391

committed

feat: Move @types/react-dom to peer dependencies

Type dependencies need to match their runtime counterpart. If `foo` is a dependency, `@types/foo` needs to be one as well. If `foo` is a peer dependency, `@types/foo` needs to be one as well. This is especially apparent if the constraint on `foo` spans multiple major versions. If we'd make `@types/foo` a direct dependency, users couldn't control which major version they get. Package managers would pick the highest. By moving `@types/foo` to peer dependencies, users can control which version of `foo` and `@types/foo` they have.

1 parent d143f46 commit d8a2391Copy full SHA for d8a2391

File tree

1 file changed

-2

lines changed

package.json

1 file changed

-2

lines changed

`‎package.json‎`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,10 +46,10 @@`
`46`	`46`	`"license": "MIT",`
`47`	`47`	`"dependencies": {`
`48`	`48`	`"@babel/runtime": "^7.12.5",`
`49`		`- "@testing-library/dom": "^10.0.0",`
`50`		`- "@types/react-dom": "^18.0.0"`
	`49`	`+ "@testing-library/dom": "^10.0.0"`
`51`	`50`	`},`
`52`	`51`	`"devDependencies": {`
	`52`	`+ "@types/react-dom": "^18.2.25",`
`53`	`53`	`"@testing-library/jest-dom": "^5.11.6",`
`54`	`54`	`"chalk": "^4.1.2",`
`55`	`55`	`"dotenv-cli": "^4.0.0",`
`@@ -62,9 +62,15 @@`
`62`	`62`	`"typescript": "^4.1.2"`
`63`	`63`	`},`
`64`	`64`	`"peerDependencies": {`
	`65`	`+ "@types/react-dom": "^18.0.0",`
`65`	`66`	`"react": "^18.0.0",`
`66`	`67`	`"react-dom": "^18.0.0"`
`67`	`68`	`},`
	`69`	`+ "peerDependenciesMeta": {`
	`70`	`+ "@types/react-dom": {`
	`71`	`+ "optional": true`
	`72`	`+ }`
	`73`	`+ },`
`68`	`74`	`"eslintConfig": {`
`69`	`75`	`"extends": "./node_modules/kcd-scripts/eslint.js",`
`70`	`76`	`"parserOptions": {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit d8a2391

File tree

1 file changed

1 file changed

`‎package.json‎`

0 commit comments