Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

renderHook from /dom/pure has global side-effects #546

Closed
arvinxx/components
#5
Labels
bugSomething isn't working released
@eps1lon

Description

  • react-hooks-testing-library version: 5.0.0
  • react-test-renderer version: not installed
  • react version: 17.0.1
  • node version: 17.0.1
  • npm (or yarn) version: yarn@1.22.0

Relevant code or config:

const { renderHook } = require("@testing-library/react-hooks/dom/pure");
let consoleError;
beforeEach(() => {
 consoleError = console.error;
});
afterEach(() => {
 if (console.error !== consoleError) {
 throw new Error("Did not cleanup console.error");
 }
});
test("pure", () => {
 function useHook() {
 return useState(false);
 }
 const { result } = renderHook(() => useHook(), {});
});

What you did:

Use @testing-library/dom/pure in karma-mocha though the problem happens in arbitrary testing frameworks I suspect

What happened:

console.error was not cleaned up

Reproduction:

https://github.com/eps1lon/testing-library-react-hooks-impure

Problem description:

We check for mistakes in afterEach if a test was not properly cleaned up. One of those checks looks at console.error.

Suggested solution:

renderHook probably has some global side-effects. These should be documented by explaining why they exists and how to disable them or work around them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working released

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /